1
0
Fork 0
mirror of https://github.com/moby/moby.git synced 2022-11-09 12:21:53 -05:00
moby--moby/integration/container
Sebastiaan van Stijn eeaa0b30d4
Skip TestHealthKillContainer on Windows
This test is failing on Windows currently:

```
11:59:47 --- FAIL: TestHealthKillContainer (8.12s)
11:59:47     health_test.go:57: assertion failed: error is not nil: Error response from daemon: Invalid signal: SIGUSR1
``

That test was added recently in https://github.com/moby/moby/pull/39454, but
rewritten in a commit in the same PR:
f8aef6a92f

In that rewrite, there were some changes:

- originally it was skipped on Windows, but the rewritten test doesn't have that skip:

    ```go
    testRequires(c, DaemonIsLinux) // busybox doesn't work on Windows
    ```

- the original test used `SIGINT`, but the new one uses `SIGUSR1`

Analysis:

- The Error bubbles up from: 8e610b2b55/pkg/signal/signal.go (L29-L44)
- Interestingly; `ContainerKill` should validate if a signal is valid for the given platform, but somehow we don't hit that part; f1b5612f20/daemon/kill.go (L40-L48)
- Windows only looks to support 2 signals currently 8e610b2b55/pkg/signal/signal_windows.go (L17-L26)
- Upstream Golang looks to define `SIGINT` as well; 77f9b2728e/src/runtime/defs_windows.go (L44)
- This looks like the current list of Signals upstream in Go; 3b58ed4ad3/windows/types_windows.go (L52-L67)

```go
const (
	// More invented values for signals
	SIGHUP  = Signal(0x1)
	SIGINT  = Signal(0x2)
	SIGQUIT = Signal(0x3)
	SIGILL  = Signal(0x4)
	SIGTRAP = Signal(0x5)
	SIGABRT = Signal(0x6)
	SIGBUS  = Signal(0x7)
	SIGFPE  = Signal(0x8)
	SIGKILL = Signal(0x9)
	SIGSEGV = Signal(0xb)
	SIGPIPE = Signal(0xd)
	SIGALRM = Signal(0xe)
	SIGTERM = Signal(0xf)
)
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
2019-07-19 16:09:50 +02:00
..
checkpoint_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
container_test.go API: properly handle invalid JSON to return a 400 status 2018-11-06 21:30:44 +01:00
copy_test.go add more tests 2019-06-13 06:31:05 +00:00
create_test.go Update more tests to use new errors 2019-03-16 00:41:02 +01:00
daemon_linux_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
diff_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
exec_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
export_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
health_test.go Skip TestHealthKillContainer on Windows 2019-07-19 16:09:50 +02:00
inspect_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
ipcmode_linux_test.go integration: change container.Create signature to fix linting 2019-06-07 13:04:44 +02:00
kill_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
links_linux_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
logs_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
main_test.go Add an integration/internal/container helper package 2018-02-10 17:29:38 +01:00
mounts_linux_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
nat_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
pause_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
ps_test.go integration: change container.Create signature to fix linting 2019-06-07 13:04:44 +02:00
remove_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
rename_test.go Merge pull request #39336 from justincormack/entropy-cannot-be-saved 2019-06-11 18:40:19 +02:00
resize_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
restart_test.go Test: Replace NewClient() with NewClientT() 2018-12-22 15:53:02 +01:00
run_cgroupns_linux_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
run_linux_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
stats_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
stop_linux_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
stop_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
stop_windows_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
update_linux_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
update_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00
wait_test.go integration: change container.Run signature to fix linting 2019-06-07 13:05:26 +02:00