mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
d17bb23ae6
In TestJSONFormatProgress, the progress string was used for comparison. However, the progress string (progress.String()) uses time.Now().UTC() to generate the timeLeftBox which is not a fixed value and cannot be compared reliably. This PR fixes the issue by stripping the timeLeftBox field before doing the comparison. This PR fixes #21124. Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
104 lines
2.9 KiB
Go
104 lines
2.9 KiB
Go
package streamformatter
|
|
|
|
import (
|
|
"encoding/json"
|
|
"errors"
|
|
"reflect"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/docker/docker/pkg/jsonmessage"
|
|
)
|
|
|
|
func TestFormatStream(t *testing.T) {
|
|
sf := NewStreamFormatter()
|
|
res := sf.FormatStream("stream")
|
|
if string(res) != "stream"+"\r" {
|
|
t.Fatalf("%q", res)
|
|
}
|
|
}
|
|
|
|
func TestFormatJSONStatus(t *testing.T) {
|
|
sf := NewStreamFormatter()
|
|
res := sf.FormatStatus("ID", "%s%d", "a", 1)
|
|
if string(res) != "a1\r\n" {
|
|
t.Fatalf("%q", res)
|
|
}
|
|
}
|
|
|
|
func TestFormatSimpleError(t *testing.T) {
|
|
sf := NewStreamFormatter()
|
|
res := sf.FormatError(errors.New("Error for formatter"))
|
|
if string(res) != "Error: Error for formatter\r\n" {
|
|
t.Fatalf("%q", res)
|
|
}
|
|
}
|
|
|
|
func TestJSONFormatStream(t *testing.T) {
|
|
sf := NewJSONStreamFormatter()
|
|
res := sf.FormatStream("stream")
|
|
if string(res) != `{"stream":"stream"}`+"\r\n" {
|
|
t.Fatalf("%q", res)
|
|
}
|
|
}
|
|
|
|
func TestJSONFormatStatus(t *testing.T) {
|
|
sf := NewJSONStreamFormatter()
|
|
res := sf.FormatStatus("ID", "%s%d", "a", 1)
|
|
if string(res) != `{"status":"a1","id":"ID"}`+"\r\n" {
|
|
t.Fatalf("%q", res)
|
|
}
|
|
}
|
|
|
|
func TestJSONFormatSimpleError(t *testing.T) {
|
|
sf := NewJSONStreamFormatter()
|
|
res := sf.FormatError(errors.New("Error for formatter"))
|
|
if string(res) != `{"errorDetail":{"message":"Error for formatter"},"error":"Error for formatter"}`+"\r\n" {
|
|
t.Fatalf("%q", res)
|
|
}
|
|
}
|
|
|
|
func TestJSONFormatJSONError(t *testing.T) {
|
|
sf := NewJSONStreamFormatter()
|
|
err := &jsonmessage.JSONError{Code: 50, Message: "Json error"}
|
|
res := sf.FormatError(err)
|
|
if string(res) != `{"errorDetail":{"code":50,"message":"Json error"},"error":"Json error"}`+"\r\n" {
|
|
t.Fatalf("%q", res)
|
|
}
|
|
}
|
|
|
|
func TestJSONFormatProgress(t *testing.T) {
|
|
sf := NewJSONStreamFormatter()
|
|
progress := &jsonmessage.JSONProgress{
|
|
Current: 15,
|
|
Total: 30,
|
|
Start: 1,
|
|
}
|
|
res := sf.FormatProgress("id", "action", progress, nil)
|
|
msg := &jsonmessage.JSONMessage{}
|
|
if err := json.Unmarshal(res, msg); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if msg.ID != "id" {
|
|
t.Fatalf("ID must be 'id', got: %s", msg.ID)
|
|
}
|
|
if msg.Status != "action" {
|
|
t.Fatalf("Status must be 'action', got: %s", msg.Status)
|
|
}
|
|
|
|
// The progress will always be in the format of:
|
|
// [=========================> ] 15 B/30 B 404933h7m11s
|
|
// The last entry '404933h7m11s' is the timeLeftBox.
|
|
// However, the timeLeftBox field may change as progress.String() depends on time.Now().
|
|
// Therefore, we have to strip the timeLeftBox from the strings to do the comparison.
|
|
|
|
// Compare the progress strings before the timeLeftBox
|
|
expectedProgress := "[=========================> ] 15 B/30 B"
|
|
if !strings.HasPrefix(msg.ProgressMessage, expectedProgress) {
|
|
t.Fatalf("ProgressMessage without the timeLeftBox must be %s, got: %s", expectedProgress, msg.ProgressMessage)
|
|
}
|
|
|
|
if !reflect.DeepEqual(msg.Progress, progress) {
|
|
t.Fatal("Original progress not equals progress from FormatProgress")
|
|
}
|
|
}
|