mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
1cd1925acd
The runtime spec expects the FileMode field to only hold file permissions, however `unix.Stat_t.Mode` contains both file type and mode. This patch strips file type so that only file mode is included in the Device. Thanks to Iceber Gu, who noticed the same issue in containerd and runc. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
31 lines
685 B
Go
31 lines
685 B
Go
package oci
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
|
|
"github.com/opencontainers/runc/libcontainer/configs"
|
|
"golang.org/x/sys/unix"
|
|
"gotest.tools/v3/assert"
|
|
)
|
|
|
|
func TestDeviceMode(t *testing.T) {
|
|
tests := []struct {
|
|
name string
|
|
in os.FileMode
|
|
out os.FileMode
|
|
}{
|
|
{name: "regular permissions", in: 0777, out: 0777},
|
|
{name: "block device", in: 0777 | unix.S_IFBLK, out: 0777},
|
|
{name: "character device", in: 0777 | unix.S_IFCHR, out: 0777},
|
|
{name: "fifo device", in: 0777 | unix.S_IFIFO, out: 0777},
|
|
}
|
|
|
|
for _, tc := range tests {
|
|
tc := tc
|
|
t.Run(tc.name, func(t *testing.T) {
|
|
d := Device(&configs.Device{FileMode: tc.in})
|
|
assert.Equal(t, *d.FileMode, tc.out)
|
|
})
|
|
}
|
|
}
|