mirror of
https://github.com/moby/moby.git
synced 2022-11-09 12:21:53 -05:00
7cb96ba308
Validation of Mounts was only performed on container _creation_, not on container _start_. As a result, if the host-path no longer existed when the container was started, a directory was created in the given location. This is the wrong behavior, because when using the `Mounts` API, host paths should never be created, and an error should be produced instead. This patch adds a validation step on container start, and produces an error if the host path is not found. Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
42 lines
1.2 KiB
Go
42 lines
1.2 KiB
Go
package volume
|
|
|
|
import (
|
|
"runtime"
|
|
|
|
"github.com/docker/docker/api/types/mount"
|
|
)
|
|
|
|
const (
|
|
// OSLinux is the same as runtime.GOOS on linux
|
|
OSLinux = "linux"
|
|
// OSWindows is the same as runtime.GOOS on windows
|
|
OSWindows = "windows"
|
|
)
|
|
|
|
// Parser represents a platform specific parser for mount expressions
|
|
type Parser interface {
|
|
ParseMountRaw(raw, volumeDriver string) (*MountPoint, error)
|
|
ParseMountSpec(cfg mount.Mount) (*MountPoint, error)
|
|
ParseVolumesFrom(spec string) (string, string, error)
|
|
DefaultPropagationMode() mount.Propagation
|
|
ConvertTmpfsOptions(opt *mount.TmpfsOptions, readOnly bool) (string, error)
|
|
DefaultCopyMode() bool
|
|
ValidateVolumeName(name string) error
|
|
ReadWrite(mode string) bool
|
|
IsBackwardCompatible(m *MountPoint) bool
|
|
HasResource(m *MountPoint, absPath string) bool
|
|
ValidateTmpfsMountDestination(dest string) error
|
|
ValidateMountConfig(mt *mount.Mount) error
|
|
}
|
|
|
|
// NewParser creates a parser for a given container OS, depending on the current host OS (linux on a windows host will resolve to an lcowParser)
|
|
func NewParser(containerOS string) Parser {
|
|
switch containerOS {
|
|
case OSWindows:
|
|
return &windowsParser{}
|
|
}
|
|
if runtime.GOOS == OSWindows {
|
|
return &lcowParser{}
|
|
}
|
|
return &linuxParser{}
|
|
}
|