1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00
mperham--sidekiq/.github/contributing.md

111 lines
2.4 KiB
Markdown
Raw Normal View History

2013-07-21 15:35:52 -07:00
# Contributing
2013-08-24 20:08:51 -07:00
## Issues
2015-02-05 12:24:52 -08:00
When opening an issue:
2013-07-21 15:35:52 -07:00
2015-02-05 12:24:52 -08:00
* include the full **backtrace** with your error
* include your Sidekiq initializer
* list versions you are using: Ruby, Rails, Sidekiq, OS, etc.
2013-07-21 15:35:52 -07:00
2015-02-05 12:24:52 -08:00
It's always better to include more info rather than less.
2013-07-21 15:35:52 -07:00
2015-02-05 12:24:52 -08:00
## Code
2013-07-21 15:35:52 -07:00
It's always best to open an issue before investing a lot of time into a
fix or new functionality. Functionality must meet my design goals and
vision for the project to be accepted; I would be happy to discuss how
your idea can best fit into Sidekiq.
### Local development setup
You need Redis installed and a Ruby version that fulfills the requirements in
`sidekiq.gemspec`. Then:
```
bundle install
```
And in order to run the tests and linter checks:
```
bundle exec rake
```
### Beginner's Guide to Local Development Setup
#### 1. Fork [mperham/sidekiq](https://github.com/mperham/sidekiq) project repository to your personal GitHub account
#### 2. Click 'Clone or Download' button in personal sidekiq repository and copy HTTPS URL
#### 3. On local machine, clone repository
```
git clone HTTPS-URL-FOR-PERSONAL-SIDEKIQ-REPOSITORY
```
#### 4. Navigate to your local machine's sidekiq directory
```
cd sidekiq/
```
#### 5. Set remote upstream branch
```
git remote add upstream https://github.com/mperham/sidekiq.git
```
#### 6. Install necessary gems for development and start Redis server
```
bundle install
```
```
redis-server
```
2022-07-03 12:55:31 +09:00
#### 7. Navigate to myapp (small Rails app inside Sidekiq repository used for development)
```
cd myapp/
```
#### 8. Run required migration in order to launch Rails app
```
rake db:migrate
```
#### 9. Launch Rails app
```
rails s
```
#### 10. Create feature branch and start contributing!
```
git checkout -b new_feature_name
```
### 11. Keep your forked branch up to date with changes in main repo
```
git pull upstream main
```
2014-07-17 13:53:54 -07:00
## Legal
2013-07-21 15:35:52 -07:00
2015-02-05 12:24:52 -08:00
By submitting a Pull Request, you disavow any rights or claims to any changes
submitted to the Sidekiq project and assign the copyright of
2014-07-17 13:53:54 -07:00
those changes to Contributed Systems LLC.
2014-07-19 16:22:50 -07:00
If you cannot or do not want to reassign those rights (your employment
contract for your employer may not allow this), you should not submit a PR.
Open an issue and someone else can do the work.
2014-07-17 13:53:54 -07:00
This is a legal way of saying "If you submit a PR to us, that code becomes ours".
2015-02-05 12:24:52 -08:00
99.9% of the time that's what you intend anyways; we hope it doesn't scare you
away from contributing.