diff --git a/Changes.md b/Changes.md index 98c264b8..3b122f4c 100644 --- a/Changes.md +++ b/Changes.md @@ -2,6 +2,11 @@ [Sidekiq Changes](https://github.com/mperham/sidekiq/blob/master/Changes.md) | [Sidekiq Pro Changes](https://github.com/mperham/sidekiq/blob/master/Pro-Changes.md) | [Sidekiq Enterprise Changes](https://github.com/mperham/sidekiq/blob/master/Ent-Changes.md) +HEAD +--------- + +- Remove Redis connection naming [#4479] + 6.0.6 --------- diff --git a/lib/sidekiq/redis_connection.rb b/lib/sidekiq/redis_connection.rb index d602292f..3719fb94 100644 --- a/lib/sidekiq/redis_connection.rb +++ b/lib/sidekiq/redis_connection.rb @@ -12,7 +12,6 @@ module Sidekiq options[key.to_sym] = options.delete(key) end - options[:id] = "Sidekiq-#{Sidekiq.server? ? "server" : "client"}-PID-#{::Process.pid}" unless options.key?(:id) options[:url] ||= determine_redis_provider size = if options[:size] diff --git a/test/test_redis_connection.rb b/test/test_redis_connection.rb index 1c2c80ef..cd5cf703 100644 --- a/test/test_redis_connection.rb +++ b/test/test_redis_connection.rb @@ -27,7 +27,6 @@ describe Sidekiq::RedisConnection do it "creates a pooled redis connection" do pool = Sidekiq::RedisConnection.create assert_equal Redis, pool.checkout.class - assert_equal "Sidekiq-server-PID-#{$$}", pool.checkout.connection.fetch(:id) end # Readers for these ivars should be available in the next release of @@ -207,7 +206,7 @@ describe Sidekiq::RedisConnection do assert_includes(output, ':host=>"host1", :port=>26379, :password=>"REDACTED"') assert_includes(output, ':host=>"host2", :port=>26379, :password=>"REDACTED"') assert_includes(output, ':host=>"host3", :port=>26379, :password=>"REDACTED"') - assert_includes(output, ':password=>"REDACTED", :id=>') + assert_includes(output, ':password=>"REDACTED"') end end end