From 7908675264d7d11672c3e47b4feaee2376835ee3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Lecour?= Date: Fri, 4 Oct 2013 09:18:04 +0200 Subject: [PATCH 1/2] Add a "latency" stat in the dashboard --- lib/sidekiq/web.rb | 2 ++ test/test_web.rb | 4 ++++ 2 files changed, 6 insertions(+) diff --git a/lib/sidekiq/web.rb b/lib/sidekiq/web.rb index 20807830..f8e008c8 100644 --- a/lib/sidekiq/web.rb +++ b/lib/sidekiq/web.rb @@ -315,6 +315,7 @@ module Sidekiq get '/dashboard/stats' do sidekiq_stats = Sidekiq::Stats.new + queue = Sidekiq::Queue.new redis_stats = Sidekiq.redis { |conn| conn.info }.select{ |k, v| redis_keys.include? k } content_type :json @@ -326,6 +327,7 @@ module Sidekiq enqueued: sidekiq_stats.enqueued, scheduled: sidekiq_stats.scheduled_size, retries: sidekiq_stats.retry_size, + latency: queue.latency, }, redis: redis_stats }) diff --git a/test/test_web.rb b/test/test_web.rb index b7038e19..014f2e62 100644 --- a/test/test_web.rb +++ b/test/test_web.rb @@ -324,6 +324,10 @@ class TestWeb < Sidekiq::Test it 'reports scheduled' do assert_equal 3, @response["sidekiq"]["scheduled"] end + + it 'reports latency' do + assert_equal 0, @response["sidekiq"]["latency"] + end end describe "for redis" do From ad32636d1fd04b3b464b06ca6478866d3ae7d9cd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=A9my=20Lecour?= Date: Fri, 4 Oct 2013 18:44:45 +0200 Subject: [PATCH 2/2] Stats: Rename latency to default_latency Since it reflects only the latency of the default queue it's more expressive like this. --- lib/sidekiq/web.rb | 2 +- test/test_web.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/sidekiq/web.rb b/lib/sidekiq/web.rb index f8e008c8..62ff38c2 100644 --- a/lib/sidekiq/web.rb +++ b/lib/sidekiq/web.rb @@ -327,7 +327,7 @@ module Sidekiq enqueued: sidekiq_stats.enqueued, scheduled: sidekiq_stats.scheduled_size, retries: sidekiq_stats.retry_size, - latency: queue.latency, + default_latency: queue.latency, }, redis: redis_stats }) diff --git a/test/test_web.rb b/test/test_web.rb index 014f2e62..5bf71f98 100644 --- a/test/test_web.rb +++ b/test/test_web.rb @@ -326,7 +326,7 @@ class TestWeb < Sidekiq::Test end it 'reports latency' do - assert_equal 0, @response["sidekiq"]["latency"] + assert_equal 0, @response["sidekiq"]["default_latency"] end end