kotovalexarian-likes-github/mperham--sidekiq
1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00
Code Releases Activity

Some issues found with type checking, fixes #4429

Browse source
This commit is contained in:
Mike Perham 2020-01-13 15:46:55 -08:00
parent 5f211944f3
commit 1d11ae3a01
2 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/sidekiq/logger.rb
View file

@ -83,7 +83,7 @@ module Sidekiq
# Redefined to check severity against #level, and thus the thread-local level, rather than +@level+. # Redefined to check severity against #level, and thus the thread-local level, rather than +@level+.
# FIXME: Remove when the minimum Ruby version supports overriding Logger#level. # FIXME: Remove when the minimum Ruby version supports overriding Logger#level.
def add(severity, message = nil, progname = nil, &block) def add(severity, message = nil, progname = nil, &block)
severity ||= UNKNOWN severity ||= ::Logger::UNKNOWN
progname ||= @progname progname ||= @progname
return true if @logdev.nil? || severity < level return true if @logdev.nil? || severity < level

2
lib/sidekiq/processor.rb
View file

@ -181,7 +181,7 @@ module Sidekiq
# the retry subsystem (e.g. network partition). We won't acknowledge the job # the retry subsystem (e.g. network partition). We won't acknowledge the job
# so it can be rescued when using Sidekiq Pro. # so it can be rescued when using Sidekiq Pro.
handle_exception(ex, {context: "Internal exception!", job: job_hash, jobstr: jobstr}) handle_exception(ex, {context: "Internal exception!", job: job_hash, jobstr: jobstr})
raise e raise ex
ensure ensure
if ack if ack
# We don't want a shutdown signal to interrupt job acknowledgment. # We don't want a shutdown signal to interrupt job acknowledgment.