From 1de18da24757019e0ea15d3b63786de65e98643c Mon Sep 17 00:00:00 2001 From: James Le Cuirot Date: Tue, 16 Oct 2012 14:55:04 +0100 Subject: [PATCH] The test for throwing away after too many retries didn't actually test anything! --- test/test_retry.rb | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/test/test_retry.rb b/test/test_retry.rb index b99e9969..eb3cb65d 100644 --- a/test/test_retry.rb +++ b/test/test_retry.rb @@ -90,14 +90,16 @@ class TestRetry < MiniTest::Unit::TestCase it 'throws away old messages after too many retries' do now = Time.now.utc - msg = {"class"=>"Bob", "args"=>[1, 2, "foo"], "queue"=>"default", "error_message"=>"kerblammo!", "error_class"=>"RuntimeError", "failed_at"=>now, "retry_count"=>25} + msg = {"class"=>"Bob", "args"=>[1, 2, "foo"], "queue"=>"default", "error_message"=>"kerblammo!", "error_class"=>"RuntimeError", "failed_at"=>now, "retry"=>true, "retry_count"=>25} + @redis.expect :zadd, 1, [ 'retry', String, String ] handler = Sidekiq::Middleware::Server::RetryJobs.new assert_raises RuntimeError do handler.call('', msg, 'default') do raise "kerblammo!" end end - @redis.verify + # MiniTest can't assert that a method call did NOT happen!? + assert_raises(MockExpectationError) { @redis.verify } end end