From 1e37c199e8634d205cf6237a2593addf74f90f8b Mon Sep 17 00:00:00 2001 From: Mike Perham Date: Tue, 22 Nov 2016 09:32:36 -0800 Subject: [PATCH] Add new appraise task to verify Sidekiq job processing in Rails 4/5 dev/prod, #3241 --- Changes.md | 9 +++++++++ lib/sidekiq/cli.rb | 2 +- lib/sidekiq/version.rb | 2 +- myapp/Rakefile | 2 ++ 4 files changed, 13 insertions(+), 2 deletions(-) diff --git a/Changes.md b/Changes.md index edb0678d..7e56627c 100644 --- a/Changes.md +++ b/Changes.md @@ -1,5 +1,14 @@ # Sidekiq Changes +4.2.7 +----------- + +- Add new integration testing to verify code loading and job execution + in development and production modes with Rails 4 and 5 [#3241] +- Fix delayed extensions in development mode [#3227, DarthSim] +- Use Worker's `retry` default if job payload does not have a retry + attribute [#3234, mlarraz] + 4.2.6 ----------- diff --git a/lib/sidekiq/cli.rb b/lib/sidekiq/cli.rb index bf2412dc..cdd03666 100644 --- a/lib/sidekiq/cli.rb +++ b/lib/sidekiq/cli.rb @@ -229,7 +229,7 @@ module Sidekiq require 'sidekiq/rails' require File.expand_path("#{options[:require]}/config/environment.rb") ::Rails.application.eager_load! - elsif ::Rails::VERSION::MAJOR >= 4 && environment != 'development' + elsif ::Rails::VERSION::MAJOR == 4 # Painful contortions, see 1791 for discussion # No autoloading, we want to force eager load for everything. require File.expand_path("#{options[:require]}/config/application.rb") diff --git a/lib/sidekiq/version.rb b/lib/sidekiq/version.rb index 6f64ba84..1f05ac27 100644 --- a/lib/sidekiq/version.rb +++ b/lib/sidekiq/version.rb @@ -1,4 +1,4 @@ # frozen_string_literal: true module Sidekiq - VERSION = "4.2.6" + VERSION = "4.2.7" end diff --git a/myapp/Rakefile b/myapp/Rakefile index 7e6db960..230b8d8c 100644 --- a/myapp/Rakefile +++ b/myapp/Rakefile @@ -54,3 +54,5 @@ task :appraise do end exit(failed ? -1 : 0) end + +task :default => :appraise