1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00

Minimize Ruby warnings in test suite

This commit is contained in:
Mike Perham 2016-11-23 14:50:11 -08:00
parent e216aa41ca
commit 257b96094f
4 changed files with 29 additions and 75 deletions

View file

@ -1,8 +1,7 @@
require 'bundler/gem_tasks'
require 'rake/testtask'
Rake::TestTask.new(:test) do |test|
#SO MUCH NOISE
#test.warning = true
test.warning = true
test.pattern = 'test/**/test_*.rb'
end

View file

@ -174,15 +174,15 @@ class TestApi < Sidekiq::Test
before do
ActiveJob::Base.queue_adapter = :sidekiq
ActiveJob::Base.logger = nil
end
class ApiMailer < ActionMailer::Base
def test_email(*)
end
class ApiMailer < ActionMailer::Base
def test_email(*)
end
end
class ApiJob < ActiveJob::Base
def perform(*)
end
class ApiJob < ActiveJob::Base
def perform(*)
end
end

View file

@ -117,10 +117,12 @@ class TestExtensions < Sidekiq::Test
Sidekiq.instance_eval { remove_instance_variable :@delay_removed }
# Reload modified modules
load 'sidekiq/extensions/action_mailer.rb'
load 'sidekiq/extensions/active_record.rb'
load 'sidekiq/extensions/generic_proxy.rb'
load 'sidekiq/extensions/class_methods.rb'
silence_warnings do
load 'sidekiq/extensions/action_mailer.rb'
load 'sidekiq/extensions/active_record.rb'
load 'sidekiq/extensions/generic_proxy.rb'
load 'sidekiq/extensions/class_methods.rb'
end
end
end

View file

@ -414,73 +414,26 @@ class TestWeb < Sidekiq::Test
2.times { add_retry }
3.times { add_scheduled }
4.times { add_worker }
end
it 'works' do
get '/stats'
@response = Sidekiq.load_json(last_response.body)
end
it 'can refresh dashboard stats' do
assert_equal 200, last_response.status
end
describe "for sidekiq" do
it 'are namespaced' do
assert_includes @response.keys, "sidekiq"
end
it 'reports processed' do
assert_equal 5, @response["sidekiq"]["processed"]
end
it 'reports failed' do
assert_equal 2, @response["sidekiq"]["failed"]
end
it 'reports busy' do
assert_equal 4, @response["sidekiq"]["busy"]
end
it 'reports processes' do
assert_equal 1, @response["sidekiq"]["processes"]
end
it 'reports retries' do
assert_equal 2, @response["sidekiq"]["retries"]
end
it 'reports scheduled' do
assert_equal 3, @response["sidekiq"]["scheduled"]
end
it 'reports latency' do
assert_equal 0, @response["sidekiq"]["default_latency"]
end
end
describe "for redis" do
it 'are namespaced' do
assert_includes @response.keys, "redis"
end
it 'reports version' do
assert_includes @response["redis"].keys, "redis_version"
end
it 'reports uptime' do
assert_includes @response["redis"].keys, "uptime_in_days"
end
it 'reports connected clients' do
assert_includes @response["redis"].keys, "connected_clients"
end
it 'reports user memory' do
assert_includes @response["redis"].keys, "used_memory_human"
end
it 'reports memory peak' do
assert_includes @response["redis"].keys, "used_memory_peak_human"
end
assert_includes @response.keys, "sidekiq"
assert_equal 5, @response["sidekiq"]["processed"]
assert_equal 2, @response["sidekiq"]["failed"]
assert_equal 4, @response["sidekiq"]["busy"]
assert_equal 1, @response["sidekiq"]["processes"]
assert_equal 2, @response["sidekiq"]["retries"]
assert_equal 3, @response["sidekiq"]["scheduled"]
assert_equal 0, @response["sidekiq"]["default_latency"]
assert_includes @response.keys, "redis"
assert_includes @response["redis"].keys, "redis_version"
assert_includes @response["redis"].keys, "uptime_in_days"
assert_includes @response["redis"].keys, "connected_clients"
assert_includes @response["redis"].keys, "used_memory_human"
assert_includes @response["redis"].keys, "used_memory_peak_human"
end
end