Minimize Ruby warnings in test suite

Rakefile

@@ -1,8 +1,7 @@
 require 'bundler/gem_tasks'
 require 'rake/testtask'
 Rake::TestTask.new(:test) do |test|
-  #SO MUCH NOISE
+  test.warning = true
-  #test.warning = true
   test.pattern = 'test/**/test_*.rb'
 end
 

test/test_api.rb

@@ -174,6 +174,7 @@ class TestApi < Sidekiq::Test
       before do
         ActiveJob::Base.queue_adapter = :sidekiq
         ActiveJob::Base.logger = nil
+      end
 
       class ApiMailer < ActionMailer::Base
         def test_email(*)
@@ -184,7 +185,6 @@ class TestApi < Sidekiq::Test
         def perform(*)
         end
       end
-      end
 
       class ApiWorker
         include Sidekiq::Worker

test/test_extensions.rb

@@ -117,11 +117,13 @@ class TestExtensions < Sidekiq::Test
 
       Sidekiq.instance_eval { remove_instance_variable :@delay_removed }
       # Reload modified modules
+      silence_warnings do
         load 'sidekiq/extensions/action_mailer.rb'
         load 'sidekiq/extensions/active_record.rb'
         load 'sidekiq/extensions/generic_proxy.rb'
         load 'sidekiq/extensions/class_methods.rb'
       end
     end
+  end
 
 end

test/test_web.rb

@@ -414,75 +414,28 @@ class TestWeb < Sidekiq::Test
         2.times { add_retry }
         3.times { add_scheduled }
         4.times { add_worker }
+      end
 
+      it 'works' do
         get '/stats'
         @response = Sidekiq.load_json(last_response.body)
-      end
-
-      it 'can refresh dashboard stats' do
         assert_equal 200, last_response.status
-      end
-
-      describe "for sidekiq" do
-        it 'are namespaced' do
         assert_includes @response.keys, "sidekiq"
-        end
-
-        it 'reports processed' do
         assert_equal 5, @response["sidekiq"]["processed"]
-        end
-
-        it 'reports failed' do
         assert_equal 2, @response["sidekiq"]["failed"]
-        end
-
-        it 'reports busy' do
         assert_equal 4, @response["sidekiq"]["busy"]
-        end
-
-        it 'reports processes' do
         assert_equal 1, @response["sidekiq"]["processes"]
-        end
-
-        it 'reports retries' do
         assert_equal 2, @response["sidekiq"]["retries"]
-        end
-
-        it 'reports scheduled' do
         assert_equal 3, @response["sidekiq"]["scheduled"]
-        end
-
-        it 'reports latency' do
         assert_equal 0, @response["sidekiq"]["default_latency"]
-        end
-      end
-
-      describe "for redis" do
-        it 'are namespaced' do
         assert_includes @response.keys, "redis"
-        end
-
-        it 'reports version' do
         assert_includes @response["redis"].keys, "redis_version"
-        end
-
-        it 'reports uptime' do
         assert_includes @response["redis"].keys, "uptime_in_days"
-        end
-
-        it 'reports connected clients' do
         assert_includes @response["redis"].keys, "connected_clients"
-        end
-
-        it 'reports user memory' do
         assert_includes @response["redis"].keys, "used_memory_human"
-        end
-
-        it 'reports memory peak' do
         assert_includes @response["redis"].keys, "used_memory_peak_human"
       end
     end
-    end
 
     describe 'stats/queues' do
       include Sidekiq::Util