From 161893d54679731b39ace5e1459c51b46fee5dd7 Mon Sep 17 00:00:00 2001 From: Tomas Kramar Date: Thu, 19 Sep 2013 12:10:14 +0200 Subject: [PATCH 1/2] Show errors for retried jobs --- lib/sidekiq/web.rb | 6 +++++- web/locales/en.yml | 1 + web/views/retries.erb | 4 ++++ 3 files changed, 10 insertions(+), 1 deletion(-) diff --git a/lib/sidekiq/web.rb b/lib/sidekiq/web.rb index ecdf89f9..44214fe4 100644 --- a/lib/sidekiq/web.rb +++ b/lib/sidekiq/web.rb @@ -107,10 +107,14 @@ module Sidekiq [score.to_f, jid] end + def truncate(text, truncate_after_chars = 2000) + truncate_after_chars && text.size > truncate_after_chars ? "#{text[0..truncate_after_chars]}..." : text + end + def display_args(args, truncate_after_chars = 2000) args.map do |arg| a = arg.inspect - truncate_after_chars && a.size > truncate_after_chars ? "#{a[0..truncate_after_chars]}..." : a + truncate(a) end.join(", ") end diff --git a/web/locales/en.yml b/web/locales/en.yml index ead10a8f..889c645e 100644 --- a/web/locales/en.yml +++ b/web/locales/en.yml @@ -21,6 +21,7 @@ en: # <---- change this to your locale code Class: Class Job: Job Arguments: Arguments + Error: Error Extras: Extras Started: Started ShowAll: Show All diff --git a/web/views/retries.erb b/web/views/retries.erb index b922861e..a7c43caa 100644 --- a/web/views/retries.erb +++ b/web/views/retries.erb @@ -21,6 +21,7 @@ <%= t('Queue') %> <%= t('Worker') %> <%= t('Arguments') %> + <%= t('Error') %> <% @retries.each do |msg, score| %> @@ -38,6 +39,9 @@
<%= display_args(msg['args']) %>
+ +
<%= truncate("#{msg['error_class']}: #{msg['error_message']}") %>
+ <% end %> From 00b22d9717741de81a80d497de6b4928acbcb9d0 Mon Sep 17 00:00:00 2001 From: Tomas Kramar Date: Sat, 21 Sep 2013 08:03:10 +0200 Subject: [PATCH 2/2] 'Error' string localization is already defined --- web/locales/en.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/web/locales/en.yml b/web/locales/en.yml index 889c645e..ead10a8f 100644 --- a/web/locales/en.yml +++ b/web/locales/en.yml @@ -21,7 +21,6 @@ en: # <---- change this to your locale code Class: Class Job: Job Arguments: Arguments - Error: Error Extras: Extras Started: Started ShowAll: Show All