From 41493f26239574d72552ebe83ce3877f9e2ddec4 Mon Sep 17 00:00:00 2001 From: Mike Perham Date: Tue, 7 Dec 2021 14:02:59 -0800 Subject: [PATCH] Stringify perform_bulk's option hash, fixes #5081 --- lib/sidekiq/worker.rb | 3 ++- test/test_worker.rb | 4 ++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/lib/sidekiq/worker.rb b/lib/sidekiq/worker.rb index 2ebae56b..c238d305 100644 --- a/lib/sidekiq/worker.rb +++ b/lib/sidekiq/worker.rb @@ -235,8 +235,9 @@ module Sidekiq alias_method :perform_sync, :perform_inline def perform_bulk(args, batch_size: 1_000) + hash = @opts.transform_keys(&:to_s) result = args.each_slice(batch_size).flat_map do |slice| - Sidekiq::Client.push_bulk(@opts.merge("class" => @klass, "args" => slice)) + Sidekiq::Client.push_bulk(hash.merge("class" => @klass, "args" => slice)) end result.is_a?(Enumerator::Lazy) ? result.force : result diff --git a/test/test_worker.rb b/test/test_worker.rb index f05c7540..10f4ed38 100644 --- a/test/test_worker.rb +++ b/test/test_worker.rb @@ -85,7 +85,7 @@ describe Sidekiq::Worker do q = Sidekiq::Queue.new('bar') assert_equal 0, q.size - set = SetWorker.set('queue' => 'bar') + set = SetWorker.set(queue: 'bar') jids = set.perform_bulk((1..1_001).to_a.map { |x| Array(x) }) assert_equal 1_001, q.size @@ -123,7 +123,7 @@ describe Sidekiq::Worker do @name = name @recorder = recorder end - + def call(*args) @recorder << "#{@name}-before" response = yield