mirror of
https://github.com/mperham/sidekiq.git
synced 2022-11-09 13:52:34 -05:00
Fix a Sidekiq Pro tagging bug (#4933)
Issue: Tags on morgue classes do not properly apply filters when clicked. They redirect to a route that Sidekiq does not service. Steps to reproduce: 0. Create an app running Sidekiq. 0. Kill a job with a tag. 0. Click on the tag in the web UI. 0. Observe that the tag does not redirect to a route serviced by Sidekiq Rack app. Depending on how host app is configured, route will 404, redirect, or do something else as it falls through. Root cause: - It looks like Sidekiq Pro mounts the routes `/filter/dead` but the `display_tags` method links to `/filter/morgue`. Notes: - There might be other ways of fixing this problem, like change the `/filter/dead` to `/filter/morgue`. Let me know if there's any other info needed or test cases we can provide!
This commit is contained in:
parent
38f9953dfa
commit
461ef8392f
1 changed files with 1 additions and 1 deletions
|
@ -44,7 +44,7 @@
|
|||
</td>
|
||||
<td>
|
||||
<%= entry.display_class %>
|
||||
<%= display_tags(entry, "morgue") %>
|
||||
<%= display_tags(entry, "dead") %>
|
||||
</td>
|
||||
<td>
|
||||
<div class="args"><%= display_args(entry.display_args) %></div>
|
||||
|
|
Loading…
Add table
Reference in a new issue