kotovalexarian-likes-github/mperham--sidekiq
1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00
Code Releases Activity

Release redis connection in ProcessSet#each when not needed (#4327)

Browse source
This commit is contained in:
fatkodima 2019-10-09 16:43:18 +03:00 committed by Mike Perham
parent fc6bad64e9
commit 59df40520b
1 changed files with 13 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
lib/sidekiq/api.rb
View file

@ -793,30 +793,28 @@ module Sidekiq
end
def each
procs = Sidekiq.redis { |conn| conn.sscan_each("processes").to_a }.sort
result = Sidekiq.redis { |conn|
procs = conn.sscan_each("processes").to_a.sort
Sidekiq.redis do |conn|
# We're making a tradeoff here between consuming more memory instead of
# making more roundtrips to Redis, but if you have hundreds or thousands of workers,
# you'll be happier this way
result = conn.pipelined {
conn.pipelined do
procs.each do |key|
conn.hmget(key, "info", "busy", "beat", "quiet")
end
}
result.each do |info, busy, at_s, quiet|
# If a process is stopped between when we query Redis for `procs` and
# when we query for `result`, we will have an item in `result` that is
# composed of `nil` values.
next if info.nil?
hash = Sidekiq.load_json(info)
yield Process.new(hash.merge("busy" => busy.to_i, "beat" => at_s.to_f, "quiet" => quiet))
end
end
}
nil
result.each do |info, busy, at_s, quiet|
# If a process is stopped between when we query Redis for `procs` and
# when we query for `result`, we will have an item in `result` that is
# composed of `nil` values.
next if info.nil?
hash = Sidekiq.load_json(info)
yield Process.new(hash.merge("busy" => busy.to_i, "beat" => at_s.to_f, "quiet" => quiet))
end
end
# This method is not guaranteed accurate since it does not prune the set