kotovalexarian-likes-github/mperham--sidekiq
1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00
Code Releases Activity

Change "really needs" to "must" in redis_connection.rb

Browse source 
This is just a semantic change, but if the program is going to crash, I think "must have" is more prescriptive than "really needs to have". 

In my mind, "really needs to have" implies that the program will continue run but the user should do something differently in the future.
This commit is contained in:
Pete Doherty 2017-11-07 12:10:06 -05:00 • committed by Mike Perham
parent e19dd4761d
commit 5b036086c5
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/sidekiq/redis_connection.rb
View file

@ -38,7 +38,7 @@ module Sidekiq
# - enterprise's leader election
# - enterprise's cron support
def verify_sizing(size, concurrency)
raise ArgumentError, "Your Redis connection pool is too small for Sidekiq to work. Your pool has #{size} connections but really needs to have at least #{concurrency + 2}" if size <= concurrency
raise ArgumentError, "Your Redis connection pool is too small for Sidekiq to work. Your pool has #{size} connections but must have at least #{concurrency + 2}" if size <= concurrency
end
def build_client(options)