kotovalexarian-likes-github/mperham--sidekiq
1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00
Code Releases Activity

polish bad json processing

Browse source
This commit is contained in:
Mike Perham 2017-03-14 20:06:04 -07:00
parent c77fdda7d6
commit 67471e5cf2
1 changed files with 2 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
lib/sidekiq/processor.rb
View file

@ -151,17 +151,12 @@ module Sidekiq
ack = false
begin
# Treat malformed JSON like a process crash -- don't acknowledge it.
# * In Sidekiq, the error will be logged but job discarded.
# * In Sidekiq Pro, the error will be logged and the job retried when
# it is recovered by the reliability algorithm. The job may act like
# a poison pill and never execute until manually removed but job loss
# is considered worse.
# Treat malformed JSON as a special case: job goes straight to the morgue.
job_hash = nil
begin
job_hash = Sidekiq.load_json(jobstr)
rescue => ex
Sidekiq.logger.error { "Pushing job to dead queue due to invalid JSON: #{ex}" }
handle_exception(ex, { :context => "Invalid JSON for job", :jobstr => jobstr })
send_to_morgue(jobstr)
ack = true
raise