1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00

Use a regular object instead of a mock for exception data

This test doesn't assert anything about the test data itself. Therefore
using a regular object is fine.

This also fixes the build for Rubinius. The problem is that a minitest
mock object removes all kinds of methods that should be there. Since
exception_data is for example used in an array later on, it should
respond to methods like equal? and == in order to be able to behave
properly in an array.

In MRI you can get away with this, because once you go into C land, you
don't go back to Ruby until you're done. This means you can remove
methods that data structures normally depend on without MRI breaking.
This commit is contained in:
Dirkjan Bussink 2012-11-05 23:04:28 +01:00
parent fb4850bdf1
commit 68f09786ff

View file

@ -115,7 +115,7 @@ class TestExceptionHandler < MiniTest::Unit::TestCase
it "notifies Exceptional" do
::Exceptional::Config.expect(:should_send_to_api?,true)
exception_data = MiniTest::Mock.new
exception_data = Object.new
::Exceptional::Remote.expect(:error,nil,[exception_data])
::Exceptional::ExceptionData.expect(:new,exception_data,[TEST_EXCEPTION])
Component.new.invoke_exception(:c => 3)