1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00

Merge pull request #390 from ezkl/respect-airbrake-ignore

Stop Airbrake notifications of ignored exceptions
This commit is contained in:
Mike Perham 2012-09-06 11:13:55 -07:00
commit 941098ad39
3 changed files with 3 additions and 2 deletions

View file

@ -5,6 +5,7 @@
- Upgrade Twitter Bootstrap to 2.1.0 - Upgrade Twitter Bootstrap to 2.1.0
- Rescue more Exceptions - Rescue more Exceptions
- Change Job ID to be Hex, rather than Base64, for HTTP safety - Change Job ID to be Hex, rather than Base64, for HTTP safety
- Use `Airbrake#notify_or_ignore`
2.2.1 2.2.1
----------- -----------

View file

@ -13,7 +13,7 @@ module Sidekiq
private private
def send_to_airbrake(msg, ex) def send_to_airbrake(msg, ex)
::Airbrake.notify(ex, :parameters => msg) ::Airbrake.notify_or_ignore(ex, :parameters => msg)
end end
def send_to_exceptional(msg, ex) def send_to_exceptional(msg, ex)

View file

@ -49,7 +49,7 @@ class TestExceptionHandler < MiniTest::Unit::TestCase
end end
it "notifies Airbrake" do it "notifies Airbrake" do
::Airbrake.expect(:notify,nil,[TEST_EXCEPTION,:parameters => { :a => 1 }]) ::Airbrake.expect(:notify_or_ignore,nil,[TEST_EXCEPTION,:parameters => { :a => 1 }])
Component.new.invoke_exception(:a => 1) Component.new.invoke_exception(:a => 1)
::Airbrake.verify ::Airbrake.verify
end end