kotovalexarian-likes-github/mperham--sidekiq
1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00
Code Releases Activity

Remove deprecated retries_exhausted support

Browse source
This commit is contained in:
Mike Perham 2014-02-01 21:25:24 -08:00
parent e8088e38fa
commit 967e0a5eb7
2 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Changes.md
View file

@ -9,8 +9,8 @@
- Removed the 'started' worker data, it originally provided compatibility with resque-web
but overlaps the 'run_at' worker data.
- Remove built-in error integration for Airbrake, Honeybadger, ExceptionNotifier and Exceptional
- Remove Sidekiq::Client.registered\_\* APIs
- Remove deprecated Sidekiq::Client.registered\_\* APIs
- Remove deprecated support for the old Sidekiq::Worker#retries\_exhausted method.
2.17.4

6
lib/sidekiq/middleware/server/retry_jobs.rb
View file

@ -110,13 +110,9 @@ module Sidekiq
def retries_exhausted(worker, msg)
logger.debug { "Dropping message after hitting the retry maximum: #{msg}" }
if worker.respond_to?(:retries_exhausted)
logger.warn { "Defining #{worker.class.name}#retries_exhausted as a method is deprecated, use `sidekiq_retries_exhausted` callback instead http://git.io/Ijju8g" }
worker.retries_exhausted(*msg['args'])
elsif worker.sidekiq_retries_exhausted_block?
if worker.sidekiq_retries_exhausted_block?
worker.sidekiq_retries_exhausted_block.call(msg)
end
rescue Exception => e
handle_exception(e, { :context => "Error calling retries_exhausted" })
end