From 5abcbb44512b532bbfc777f3f1f40449712a69e1 Mon Sep 17 00:00:00 2001 From: Abdelkader Boudih Date: Tue, 16 Sep 2014 17:53:38 +0000 Subject: [PATCH 1/2] added pry-byebug to the sample app --- myapp/Gemfile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/myapp/Gemfile b/myapp/Gemfile index 09074eb1..3a4087c6 100644 --- a/myapp/Gemfile +++ b/myapp/Gemfile @@ -11,7 +11,7 @@ end gem 'rails', '~> 4.1.1' gem 'sidekiq', :path => '..' -gem 'capistrano' +gem 'pry-byebug' # sidekiq-web dependencies gem 'sinatra' From 9660ea9020349a8dfecb20d0fc0ab47cfb020690 Mon Sep 17 00:00:00 2001 From: Abdelkader Boudih Date: Tue, 16 Sep 2014 17:55:50 +0000 Subject: [PATCH 2/2] Don't return 404 when no key is provided, redirect to the get request instead. --- lib/sidekiq/web.rb | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/lib/sidekiq/web.rb b/lib/sidekiq/web.rb index 78bd1f3b..c66b005e 100644 --- a/lib/sidekiq/web.rb +++ b/lib/sidekiq/web.rb @@ -133,14 +133,13 @@ module Sidekiq end get "/retries/:key" do - halt 404 unless params['key'] @retry = Sidekiq::RetrySet.new.fetch(*parse_params(params['key'])).first redirect "#{root_path}retries" if @retry.nil? erb :retry end post '/retries' do - halt 404 unless params['key'] + redirect request.path unless params['key'] params['key'].each do |key| job = Sidekiq::RetrySet.new.fetch(*parse_params(key)).first @@ -160,7 +159,6 @@ module Sidekiq end post "/retries/:key" do - halt 404 unless params['key'] job = Sidekiq::RetrySet.new.fetch(*parse_params(params['key'])).first retry_or_delete_or_kill job, params if job redirect_with_query("#{root_path}retries") @@ -174,14 +172,13 @@ module Sidekiq end get "/scheduled/:key" do - halt 404 unless params['key'] @job = Sidekiq::ScheduledSet.new.fetch(*parse_params(params['key'])).first redirect "#{root_path}scheduled" if @job.nil? erb :scheduled_job_info end post '/scheduled' do - halt 404 unless params['key'] + redirect request.path unless params['key'] params['key'].each do |key| job = Sidekiq::ScheduledSet.new.fetch(*parse_params(key)).first