1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00

Revert "Use MultiJson APIs introduced in version 1.3 to suppress deprecation warnings"

Breaks Rails 3.2 and lower

This reverts commit 9c6d5623a1.
This commit is contained in:
Mike Perham 2012-04-18 14:57:24 -07:00
parent 1eac454765
commit 9c6b967029
11 changed files with 25 additions and 25 deletions

View file

@ -38,7 +38,7 @@ module Sidekiq
pushed = false pushed = false
Sidekiq.client_middleware.invoke(worker_class, item, queue) do Sidekiq.client_middleware.invoke(worker_class, item, queue) do
payload = MultiJson.dump(item) payload = MultiJson.encode(item)
Sidekiq.redis do |conn| Sidekiq.redis do |conn|
_, pushed = conn.multi do _, pushed = conn.multi do
conn.sadd('queues', queue) conn.sadd('queues', queue)

View file

@ -110,7 +110,7 @@ module Sidekiq
processor = @ready.pop processor = @ready.pop
@in_progress[processor.object_id] = [msg, queue] @in_progress[processor.object_id] = [msg, queue]
@busy << processor @busy << processor
processor.process!(MultiJson.load(msg), queue) processor.process!(MultiJson.decode(msg), queue)
end end
end end
end end

View file

@ -10,7 +10,7 @@ module Sidekiq
def call(worker_class, item, queue) def call(worker_class, item, queue)
enabled = worker_class.get_sidekiq_options['unique'] enabled = worker_class.get_sidekiq_options['unique']
if enabled if enabled
payload_hash = Digest::MD5.hexdigest(MultiJson.dump(item)) payload_hash = Digest::MD5.hexdigest(MultiJson.encode(item))
unique = false unique = false
Sidekiq.redis do |conn| Sidekiq.redis do |conn|

View file

@ -15,7 +15,7 @@ module Sidekiq
:queue => args[2] :queue => args[2]
} }
Sidekiq.redis {|conn| conn.rpush(:failed, MultiJson.dump(data)) } Sidekiq.redis {|conn| conn.rpush(:failed, MultiJson.encode(data)) }
raise raise
end end
end end

View file

@ -44,7 +44,7 @@ module Sidekiq
delay = DELAY.call(count) delay = DELAY.call(count)
logger.debug { "Failure! Retry #{count} in #{delay} seconds" } logger.debug { "Failure! Retry #{count} in #{delay} seconds" }
retry_at = Time.now.to_f + delay retry_at = Time.now.to_f + delay
payload = MultiJson.dump(msg) payload = MultiJson.encode(msg)
Sidekiq.redis do |conn| Sidekiq.redis do |conn|
conn.zadd('retry', retry_at.to_s, payload) conn.zadd('retry', retry_at.to_s, payload)
end end

View file

@ -5,7 +5,7 @@ module Sidekiq
def call(*args) def call(*args)
yield yield
ensure ensure
json = MultiJson.dump(args[1]) json = MultiJson.encode(args[1])
hash = Digest::MD5.hexdigest(json) hash = Digest::MD5.hexdigest(json)
Sidekiq.redis {|conn| conn.del(hash) } Sidekiq.redis {|conn| conn.del(hash) }
end end

View file

@ -53,7 +53,7 @@ module Sidekiq
redis do |conn| redis do |conn|
conn.multi do conn.multi do
conn.set("worker:#{self}:started", Time.now.to_s) conn.set("worker:#{self}:started", Time.now.to_s)
conn.set("worker:#{self}", MultiJson.dump(:queue => queue, :payload => msg, conn.set("worker:#{self}", MultiJson.encode(:queue => queue, :payload => msg,
:run_at => Time.now.strftime("%Y/%m/%d %H:%M:%S %Z"))) :run_at => Time.now.strftime("%Y/%m/%d %H:%M:%S %Z")))
end end
end end

View file

@ -46,7 +46,7 @@ module Sidekiq
messages.each do |message| messages.each do |message|
logger.debug { "Retrying #{message}" } logger.debug { "Retrying #{message}" }
msg = MultiJson.load(message) msg = MultiJson.decode(message)
conn.rpush("queue:#{msg['queue']}", message) conn.rpush("queue:#{msg['queue']}", message)
end end
end end

View file

@ -52,7 +52,7 @@ module Sidekiq
Sidekiq.redis do |conn| Sidekiq.redis do |conn|
conn.smembers('workers').map do |w| conn.smembers('workers').map do |w|
msg = conn.get("worker:#{w}") msg = conn.get("worker:#{w}")
msg = MultiJson.load(msg) if msg msg = MultiJson.decode(msg) if msg
[w, msg] [w, msg]
end.sort { |x| x[1] ? -1 : 1 } end.sort { |x| x[1] ? -1 : 1 }
end end
@ -74,7 +74,7 @@ module Sidekiq
def retries def retries
Sidekiq.redis do |conn| Sidekiq.redis do |conn|
results = conn.zrange('retry', 0, 25, :withscores => true) results = conn.zrange('retry', 0, 25, :withscores => true)
results.each_slice(2).map { |msg, score| [MultiJson.load(msg), Float(score)] } results.each_slice(2).map { |msg, score| [MultiJson.decode(msg), Float(score)] }
end end
end end
@ -89,7 +89,7 @@ module Sidekiq
def retries_with_score(score) def retries_with_score(score)
Sidekiq.redis do |conn| Sidekiq.redis do |conn|
results = conn.zrangebyscore('retry', score, score) results = conn.zrangebyscore('retry', score, score)
results.map { |msg| MultiJson.load(msg) } results.map { |msg| MultiJson.decode(msg) }
end end
end end
@ -124,7 +124,7 @@ module Sidekiq
get "/queues/:name" do get "/queues/:name" do
halt 404 unless params[:name] halt 404 unless params[:name]
@name = params[:name] @name = params[:name]
@messages = Sidekiq.redis {|conn| conn.lrange("queue:#{@name}", 0, 10) }.map { |str| MultiJson.load(str) } @messages = Sidekiq.redis {|conn| conn.lrange("queue:#{@name}", 0, 10) }.map { |str| MultiJson.decode(str) }
slim :queue slim :queue
end end
@ -142,7 +142,7 @@ module Sidekiq
results = conn.zrangebyscore('retry', score, score) results = conn.zrangebyscore('retry', score, score)
conn.zremrangebyscore('retry', score, score) conn.zremrangebyscore('retry', score, score)
results.map do |message| results.map do |message|
msg = MultiJson.load(message) msg = MultiJson.decode(message)
conn.rpush("queue:#{msg['queue']}", message) conn.rpush("queue:#{msg['queue']}", message)
end end
end end

View file

@ -13,15 +13,15 @@ Gem::Specification.new do |gem|
gem.name = "sidekiq" gem.name = "sidekiq"
gem.require_paths = ["lib"] gem.require_paths = ["lib"]
gem.version = Sidekiq::VERSION gem.version = Sidekiq::VERSION
gem.add_dependency 'redis' gem.add_dependency 'redis'
gem.add_dependency 'redis-namespace' gem.add_dependency 'redis-namespace'
gem.add_dependency 'connection_pool', '~> 0.9.0' gem.add_dependency 'connection_pool', '~> 0.9.0'
gem.add_dependency 'celluloid', '~> 0.10.0' gem.add_dependency 'celluloid', '~> 0.10.0'
gem.add_dependency 'multi_json', '~> 1.3' gem.add_dependency 'multi_json', '~> 1'
gem.add_development_dependency 'minitest' gem.add_development_dependency 'minitest'
gem.add_development_dependency 'sinatra' gem.add_development_dependency 'sinatra'
gem.add_development_dependency 'slim' gem.add_development_dependency 'slim'
gem.add_development_dependency 'rake' gem.add_development_dependency 'rake'
gem.add_development_dependency 'actionmailer', '~> 3' gem.add_development_dependency 'actionmailer', '~> 3'
gem.add_development_dependency 'activerecord', '~> 3' gem.add_development_dependency 'activerecord', '~> 3'
end end

View file

@ -81,7 +81,7 @@ class TestRetry < MiniTest::Unit::TestCase
end end
it 'should poll like a bad mother...SHUT YO MOUTH' do it 'should poll like a bad mother...SHUT YO MOUTH' do
fake_msg = MultiJson.dump({ 'class' => 'Bob', 'args' => [1,2], 'queue' => 'someq' }) fake_msg = MultiJson.encode({ 'class' => 'Bob', 'args' => [1,2], 'queue' => 'someq' })
@redis.expect :multi, [[fake_msg], 1], [] @redis.expect :multi, [[fake_msg], 1], []
@redis.expect :rpush, 1, ['queue:someq', fake_msg] @redis.expect :rpush, 1, ['queue:someq', fake_msg]