From a1f98fbbf2059fdcf97d6f4c1919f5facbead734 Mon Sep 17 00:00:00 2001 From: David Date: Fri, 15 Apr 2016 04:59:13 +0000 Subject: [PATCH] log context as a JSON string --- lib/sidekiq/exception_handler.rb | 2 +- test/test_exception_handler.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/sidekiq/exception_handler.rb b/lib/sidekiq/exception_handler.rb index a788c9a3..a4d9dc0f 100644 --- a/lib/sidekiq/exception_handler.rb +++ b/lib/sidekiq/exception_handler.rb @@ -5,7 +5,7 @@ module Sidekiq class Logger def call(ex, ctxHash) - Sidekiq.logger.warn(ctxHash) if !ctxHash.empty? + Sidekiq.logger.warn(Sidekiq.dump_json(ctxHash)) if !ctxHash.empty? Sidekiq.logger.warn "#{ex.class.name}: #{ex.message}" Sidekiq.logger.warn ex.backtrace.join("\n") unless ex.backtrace.nil? end diff --git a/test/test_exception_handler.rb b/test/test_exception_handler.rb index e9e1aecc..8c04a159 100644 --- a/test/test_exception_handler.rb +++ b/test/test_exception_handler.rb @@ -32,7 +32,7 @@ class TestExceptionHandler < Sidekiq::Test Component.new.invoke_exception(:a => 1) @str_logger.rewind log = @str_logger.readlines - assert_match(/a=>1/, log[0], "didn't include the context") + assert_match(/"a":1/, log[0], "didn't include the context") assert_match(/Something didn't work!/, log[1], "didn't include the exception message") assert_match(/test\/test_exception_handler.rb/, log[2], "didn't include the backtrace") end