kotovalexarian-likes-github/mperham--sidekiq
1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00
Code Releases Activity

Follow generator configuration to determine the resulting test file (#4371)

Browse source 
Verifying that `RSpec` is defined assumes that the library is loaded on
the same environment that the generator is running.

It is often common to not have the rspec gem required on development,
which is the default environment to run the generator from.

Following the configured generator removes the assumption and works as
expected without breaking expectations.
This commit is contained in:
Luiz Felipe G. Pereira 2019-11-11 15:37:39 -03:00 • committed by Mike Perham
parent 4eb85f9369
commit bb8871e3d1
2 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/generators/sidekiq/worker_generator.rb
View file

@ -18,7 +18,7 @@ module Sidekiq
def create_test_file
return unless test_framework
if defined?(RSpec)
if test_framework == :rspec
create_worker_spec
else
create_worker_test

15
test/test_worker_generator.rb
View file

@ -38,4 +38,19 @@ class WorkerGeneratorTest < Rails::Generators::TestCase
g.test_framework :test_case
end
end
test 'respects rails config test_framework option for rspec' do
Rails.application.config.generators do |g|
g.test_framework :rspec
end
run_generator ['foo']
assert_file 'app/workers/foo_worker.rb'
assert_file 'spec/workers/foo_worker_spec.rb'
ensure
Rails.application.config.generators do |g|
g.test_framework :test_case
end
end
end