Clean up warnings seen with RUBYOPT="-w", fixes #2402

bin/sidekiq

@@ -1,5 +1,10 @@
 #!/usr/bin/env ruby
 
+# Quiet some warnings we see when running in warning mode:
+# RUBYOPT=-w bundle exec sidekiq
+$TESTING = false
+$CELLULOID_DEBUG = false
+
 require_relative '../lib/sidekiq/cli'
 
 begin

lib/sidekiq/fetch.rb

@@ -83,7 +83,7 @@ module Sidekiq
     end
 
     def self.done?
-      @done
+      defined? @done
     end
 
     def self.strategy

lib/sidekiq/web_helpers.rb

@@ -45,7 +45,7 @@ module Sidekiq
     end
 
     def display_custom_head
-      return unless @head_html
+      return unless defined?(@head_html)
       @head_html.map { |block| capture(&block) }.join
     end
 

test/helper.rb

@@ -1,3 +1,4 @@
+$CELLULOID_DEBUG = false
 $TESTING = true
 require 'coveralls'
 Coveralls.wear! do

test/test_retry.rb

@@ -354,7 +354,7 @@ class TestRetry < Sidekiq::Test
           rescue ::StandardError => e1
             begin
               raise ::StandardError, 'Error 2'
-            rescue ::StandardError => e2
+            rescue ::StandardError => _
               raise e1
             end
           end

test/test_scheduled.rb

@@ -98,8 +98,8 @@ class TestScheduled < Sidekiq::Test
         i = 500
         intervals = i.times.map{ @poller.send(:random_poll_interval) }
 
-        assert intervals.all?{|i| i >= 5}
-        assert intervals.all?{|i| i <= 15}
+        assert intervals.all?{|x| x >= 5}
+        assert intervals.all?{|x| x <= 15}
         assert_in_delta 10, intervals.reduce(&:+).to_f / i, 0.5
       end
     end

test/test_web.rb

@@ -292,7 +292,7 @@ class TestWeb < Sidekiq::Test
 
       get '/queues/default'
       assert_equal 200, last_response.status
-      assert_match /#{msg['args'][2]}/, last_response.body
+      assert_match(/#{msg['args'][2]}/, last_response.body)
     end
 
     it 'calls updatePage() once when polling' do