From d8cd87aa1ea0ad4a06378748e85898587a00a5f4 Mon Sep 17 00:00:00 2001
From: Jonathan Hyman <jonathan.hyman@post.harvard.edu>
Date: Thu, 25 Jul 2013 18:36:23 -0400
Subject: [PATCH] No longer truncates arguments in sidekiq-web, instead uses
 overflow: scroll to let you see them.

---
 Changes.md                             | 1 +
 web/assets/stylesheets/application.css | 6 +++++-
 web/views/retries.slim                 | 3 ++-
 web/views/retry.slim                   | 3 ++-
 web/views/scheduled.slim               | 3 ++-
 5 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/Changes.md b/Changes.md
index 7c3782b1..da893189 100644
--- a/Changes.md
+++ b/Changes.md
@@ -1,6 +1,7 @@
 2.13.1
 -----------
 - Make summary bar and graphs responsive [manishval] [#1025]
+- No longer truncates args in sidekiq-web, instead sets `overflow: scroll` [jonhyman]
 
 2.13.0
 -----------
diff --git a/web/assets/stylesheets/application.css b/web/assets/stylesheets/application.css
index 62d2b058..6b68b0cd 100755
--- a/web/assets/stylesheets/application.css
+++ b/web/assets/stylesheets/application.css
@@ -844,4 +844,8 @@ img.smallogo {
 .rickshaw_legend li:active {
   background: rgba(255, 255, 255, 0.2);
   border-radius: 3px;
-}
\ No newline at end of file
+}
+.args {
+  overflow: scroll;
+  max-height: 100px;
+}
diff --git a/web/views/retries.slim b/web/views/retries.slim
index 44649985..f43d8203 100644
--- a/web/views/retries.slim
+++ b/web/views/retries.slim
@@ -27,7 +27,8 @@ header.row
           td
             a href="#{root_path}queues/#{msg['queue']}" #{msg['queue']}
           td= msg['class']
-          td= display_args(msg['args'])
+          td
+            div.args=display_args(msg['args'])
     input.btn.btn-primary.btn-small.pull-left type="submit" name="retry" value="#{t('RetryNow')}"
     input.btn.btn-danger.btn-small.pull-left type="submit" name="delete" value="#{t('Delete')}"
 
diff --git a/web/views/retry.slim b/web/views/retry.slim
index f64687b5..dd289467 100644
--- a/web/views/retry.slim
+++ b/web/views/retry.slim
@@ -14,7 +14,8 @@ table class="retry table table-bordered table-striped"
     tr
       th = t('Arguments')
       td
-        code= display_args(@retry['args'], 1000)
+        code
+          div.args=display_args(@retry['args'])
     tr
       th JID
       td
diff --git a/web/views/scheduled.slim b/web/views/scheduled.slim
index 1108497f..3218d5ae 100644
--- a/web/views/scheduled.slim
+++ b/web/views/scheduled.slim
@@ -24,7 +24,8 @@ header.row
           td
             a href="#{root_path}queues/#{msg['queue']}" #{msg['queue']}
           td= msg['class']
-          td= display_args(msg['args'])
+          td
+             div.args=display_args(msg['args'])
     input.btn.btn-danger.pull-right type="submit" name="delete" value="#{t('Delete')}"
     input.btn.btn-danger.pull-right type="submit" name="add_to_queue" value="#{t('AddToQueue')}"
 - else