1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00

refactoring

This commit is contained in:
Mike Perham 2020-06-03 22:11:18 -07:00
parent 93bfa9d40e
commit eb2a6ab497

View file

@ -6,16 +6,16 @@ class TestCsrf < Minitest::Test
@session ||= {} @session ||= {}
end end
def env(opts={}) def env(method=:get, form_hash={})
imp = StringIO.new("") imp = StringIO.new("")
{ {
"REQUEST_METHOD" => "GET", "REQUEST_METHOD" => method.to_s.upcase,
"rack.session" => session, "rack.session" => session,
"rack.logger" => ::Logger.new(@logio ||= StringIO.new("")), "rack.logger" => ::Logger.new(@logio ||= StringIO.new("")),
"rack.input" => imp, "rack.input" => imp,
"rack.request.form_input" => imp, "rack.request.form_input" => imp,
"rack.request.form_hash" => {}, "rack.request.form_hash" => form_hash,
}.merge(opts) }
end end
def call(env, &block) def call(env, &block)
@ -47,7 +47,7 @@ class TestCsrf < Minitest::Test
end end
def test_bad_post def test_bad_post
result = call(env("REQUEST_METHOD" => "POST")) do result = call(env(:post)) do
raise "Shouldnt be called" raise "Shouldnt be called"
end end
refute_nil result refute_nil result
@ -67,11 +67,7 @@ class TestCsrf < Minitest::Test
assert goodtoken assert goodtoken
# Make a POST with the known good token # Make a POST with the known good token
result = call( result = call(env(:post, "authenticity_token" => goodtoken)) do
env({
"REQUEST_METHOD" => "POST",
"rack.request.form_hash" => { "authenticity_token"=>goodtoken }
})) do
[200, {}, ["OK"]] [200, {}, ["OK"]]
end end
refute_nil result refute_nil result
@ -79,11 +75,7 @@ class TestCsrf < Minitest::Test
assert_equal ["OK"], result[2] assert_equal ["OK"], result[2]
# Make a POST with a known bad token # Make a POST with a known bad token
result = call( result = call(env(:post, "authenticity_token"=>"N0QRBD34tU61d7fi+0ZaF/35JLW/9K+8kk8dc1TZoK/0pTl7GIHap5gy7BWGsoKlzbMLRp1yaDpCDFwTJtxWAg==")) do
env({
"REQUEST_METHOD" => "POST",
"rack.request.form_hash" => { "authenticity_token"=>"N0QRBD34tU61d7fi+0ZaF/35JLW/9K+8kk8dc1TZoK/0pTl7GIHap5gy7BWGsoKlzbMLRp1yaDpCDFwTJtxWAg==", },
})) do
raise "shouldnt be called" raise "shouldnt be called"
end end
refute_nil result refute_nil result