1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00
Commit graph

22 commits

Author SHA1 Message Date
Bryan FRIMIN
32c55e3165 Use standardrb for source styling (#4114) 2019-04-01 09:20:41 -07:00
Rachael Ludwick
4a7da4302d Log at error level on redis exceptions and then warn for exception
Backout previous change to the exception handler signature and instead
just log at error level the main part of the redis exception then just
use the original exception handler as-is (at warn level) for the
backtrace. This is a compromise in compatibility insofar as the
backtrace is now at a lower log level, but alerting specifically on
these error strings likely uses the main error strings explicitly logged
before the very verbose backtrace.
2017-11-30 10:11:16 -08:00
Rachael Ludwick
aead218b84 Make error handler change fully backwards compatible
The change that Fixes mperham/sidekiq#3673 actually broke any existing
exception handlers due to differences in expected parameter count. This
fixes it explicitly which normally seems like it won't matter but there
are random monitoring gems that install their own sidekiq exception
handlers that I don't want to break.
2017-11-30 10:11:16 -08:00
Rachael Ludwick
58d5ff1e6d Use exception handler for logging for fetch exception
Extends the `ExceptionHandler` to support multiple log levels and
additional context text in order to use it when the `Processor`
encounters an exception when fetching new work. The added options ensure
that the new behavior is fairly close to the old behavior (same log
level, same fetch error message).

Fixes mperham/sidekiq#3673
2017-11-22 17:37:29 -08:00
Mike Perham
72fe3289ea Merge branch 'master' into frozen 2016-04-21 13:15:00 -07:00
David
a1f98fbbf2 log context as a JSON string 2016-04-15 04:59:13 +00:00
Mike Perham
2c9f7662fc Freeze all string literals in source, fixes #2741
Tests pass and smoke test works perfectly.
2015-12-31 15:33:35 -08:00
Mike Perham
a695ff347a Pro XSS 2015-04-29 14:12:32 -07:00
Mike Perham
f39be47e64 Add global error handler feature 2014-02-24 20:47:44 -08:00
Mike Perham
9dc4e065d5 Remove built-in error notification service support 2014-02-01 21:13:34 -08:00
Lee Henson
b4e6291ca7 don't fail when handling an exception with a nil backtrace 2013-10-07 15:00:20 +01:00
Mike Perham
a8c0e28bba Whoa, reason is actually an Exception. Didn't know that. 2013-09-22 20:48:17 -07:00
Mike Perham
2b9ab89489 Ensure we always pass a Hash to handle_exception, fixes #1134 2013-08-25 12:59:33 -07:00
Wes Morgan
d6629db803 Revert "Revert "Use ExceptionNotifier.notify_exception""
This reverts commit 965f8b28ec.
2013-07-15 16:41:30 -06:00
Mike Perham
965f8b28ec Revert "Use ExceptionNotifier.notify_exception"
This reverts commit 962c7c0908.
2013-05-24 11:10:14 -07:00
Steve Randy Tantra
962c7c0908 Use ExceptionNotifier.notify_exception
This will handle ignored exceptions
2013-05-06 08:15:07 +08:00
Mike Perham
aed84fd8b2 note that we don't want more error services 2012-10-28 13:24:01 -07:00
Teng Siong Ong
4da2757801 use honeybadger for exception. 2012-10-26 20:33:54 -07:00
Ezekiel Templin
22381aa13b Use Airbrake#notify_or_ignore 2012-09-06 18:50:15 +01:00
John Firebaugh
aad8a3a1c5 Actually deliver the exception notifications 2012-08-15 14:15:10 -07:00
Mike Perham
36801315d6 Rework error handling to work with watchdog 2012-08-02 20:48:49 -07:00
Mike Subelsky
0622ac3192 extract error handling middleware into processor-level code 2012-07-31 14:30:34 -04:00