1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00
Commit graph

30 commits

Author SHA1 Message Date
Mike Perham
cfc3f314e4 escape page and poll parameters for safety 2017-02-15 09:29:17 -08:00
Mike Perham
475865e613 Ensure content-type is always set, fixes #3338 2017-02-01 10:51:35 -08:00
Mike Perham
878ffff0c9 Fix a number of issues with URL-unsafe queue names, fixes #3327 2017-01-24 10:27:50 -08:00
Mike Perham
042b61a693 Restore timestamp tooltips, fixes #3310 2017-01-08 17:00:55 -08:00
Vladimir Kochnev
1a039f5708 Fixnum -> Integer replacement and Ruby 2.4 support for Travis. (#3293)
Fixnum is deprecated in Ruby 2.4 so we should get rid of it.
2016-12-26 08:47:00 -08:00
Mike Perham
b06c1ec7f2 Remove unused method 2016-11-23 20:08:27 -08:00
Mike Perham
e537b4dffb Don’t display “All” action buttons when filtering is active, #3243 2016-11-19 13:24:13 -08:00
sebastienvercammen
ebf04857d2 I swear to god... (#3237) 2016-11-12 17:39:08 -05:00
Mike Perham
959ab0ad49 Better root URL handling for zany web servers, fixes #3207 2016-11-03 11:10:53 -07:00
Mike Perham
83430b434f Don't use shared mutable constants for headers, fixes #3169. 2016-09-29 13:24:49 -07:00
onigra
c5e2e43a5c Fix uninitialized constant Sidekiq::WebAction::CONTENT_TYPE error (#3168)
* fix uninitialized constant Sidekiq::WebAction::CONTENT_TYPE

* remove space
2016-09-29 06:33:12 -07:00
Tim Dorr
c187be6521 Redirect from no trailing slash on Web UI (#3158)
Fixes #3151

If you mount at `/sidekiq` and visit the `/sidekiq` URL, it will now redirect over to `/sidekiq/`, rather than 404ing.
2016-09-22 12:07:52 -07:00
cconstantine
ba3037d63e Freeze shared header object in rack response so the current response's rack headers don't show up in the next request. 2016-09-16 16:38:58 -07:00
Mike Perham
ad350433a8 Add no-cache to JSON response headers, fixes #3136
Also, remove a bunch of freeze noise and unnecessary constants.
2016-09-14 10:15:28 -07:00
Mike Perham
0c098787b0 Remove poll_js and inline JS script, fixes #3133 2016-09-12 14:32:54 -07:00
Mike Perham
1c05404e82 Disable Rack::ETag caching for all rendered pages, fixes #3127 2016-09-12 11:42:01 -07:00
Mike Perham
de13425b44 Fix Ruby warnings, thanks for the reminder @nateberkopec 2016-08-30 13:29:03 -07:00
Amadeus Folego
a7814923fc Unescape PATH_INFO 2016-08-02 14:47:59 -03:00
Amadeus Folego
a742e96b00 Capture only param in route :param.extension 2016-08-02 12:31:09 -03:00
Mike Perham
d2c1f491e6 web compat with Pro/Enterprise 2016-08-01 09:05:10 -07:00
Amadeus Folego
921031b5ae Change template rendering engine 2016-07-29 20:14:56 -03:00
Amadeus Folego
44614b5da2 Implement additional methods and optimize router 2016-07-29 17:56:52 -03:00
Amadeus Folego
64fa2078a1 Remove unnecessary constraints attribute 2016-07-29 16:28:27 -03:00
Amadeus Folego
cb59b5bcf7 Cache ERB templates 2016-07-29 16:16:57 -03:00
Amadeus Folego
9ae228c521 Send Content-Length header 2016-07-29 16:15:07 -03:00
Mike Perham
e8cdbd80b4 Add necessary web infrastructure to support Pro/Ent 2016-07-29 12:09:00 -07:00
Amadeus Folego
d05066dc1a Implement compatibility interface with sinatra 2016-07-29 04:45:19 -03:00
Amadeus Folego
91fd77d44e Minor cleanups and improve extension compatibility 2016-07-27 16:18:52 -03:00
Mike Perham
20e1035bea Implement several extension points 2016-07-26 22:19:56 -07:00
Amadeus Folego
9ea167db16 Migrate Sidekiq::Web to a pure Rack application
Migrate Sidekiq::Web a pure Rack application to avoid sinatra as
dependency. rack-protection is still needed.

The application is mounted on top of Rack::Builder, mantaining all of
the previous http interface.

Rack apps being used:

- Rack::File to serve assets
- Rack::Session::Cookie, the secret can be configured via
  Sidekiq::Web.session_secret
- Rack::Protection, same as before when using sinatra
- Sidekiq::WebApplication, described below.

Sidekiq::WebApplication is a very simple rack application composed of a
Sidekiq::WebRouter and a Sidekiq::WebAction dispatcher. This terminology
was adopted to be able to mantain Sidekiq::Web as a Rack app.

The Router is heavily inspired on Rack::Router[0] (and in many parts
identical), however not being retrocompatible.

The Action is a wrapper to provide convenience, DRY code and maintain
the old interface.

I tried to mantain most of the old application structures so that
customizations and monkey-patches are easily adjustable or even
further work be done to enforce retrocompatibility.

Testing welcome!

0: https://github.com/pjb3/rack-router
2016-07-26 11:43:32 -03:00