1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00
Commit graph

23 commits

Author SHA1 Message Date
Edward Anderson
2f9258e4fe Put source encoding comment as line for (j)ruby 1.9 compatibility (#3255)
In jruby 1.7.22 (1.9.3p551 compatibility mode), UTF-8 encoding is not properly
detected, because the encoding comment is not on the first line as required in ruby
1.9.

The frozen_string_literal magic comment did not come into existence until ruby 2.3,
and ruby 1.9 does not look past the first line for magic comments.

This results encoding-related syntax errors. Examples:

    SyntaxError: /home/nilbus/ws/rental_express/ROOT/rails/vendor/bundle/jruby/1.9/gems/sidekiq-4.2.6/lib/sidekiq.rb:52: Invalid char `\235' ('') in expression
      def self.❨╯°□°❩╯︵┻━┻
                ^

    SyntaxError: /home/nilbus/ws/rental_express/ROOT/rails/vendor/bundle/jruby/1.9/gems/sidekiq-4.2.6/lib/sidekiq/api.rb:269: Invalid char `\237' ('Ÿ') in expression
        alias_method :💣, :clear
                       ^

This patch should restore compatibility with ruby 1.9 and greater.
2016-11-22 20:39:00 -08:00
Mike Perham
72fe3289ea Merge branch 'master' into frozen 2016-04-21 13:15:00 -07:00
lukas
b787ed2b12 return obvious fake info when INFO is disabled 2016-02-26 00:18:46 +01:00
lukas
23c1c6bcde added Sidekiq#redis_info to encapsulate info calls 2016-02-25 23:31:30 +01:00
Mike Perham
2c9f7662fc Freeze all string literals in source, fixes #2741
Tests pass and smoke test works perfectly.
2015-12-31 15:33:35 -08:00
Mike Perham
53e6b9e2df Test suite overhaul
Remove Redis mocking.  Minimize Redis flushing where possible.
2015-09-23 10:56:37 -07:00
Mike Perham
79288de605 Disconnect and retry if READONLY error detected, fixes #2550 2015-09-11 10:55:45 -07:00
Mike Perham
846e661de4 Fix leaky global state 2015-07-13 21:51:53 -07:00
Mike Perham
4433e685ba Add helper method to encapsulate hz check, #2431 2015-07-12 10:51:34 -07:00
Mike Perham
9f772406c4 Remove coveralls, use simplecov, improve coverage 2015-07-10 12:35:02 -07:00
André Arko
0ab19249e8 Fix tests to also not be sexist 2015-04-21 13:08:30 -04:00
Abdelkader Boudih
33b9999c43 Stringify Sidekiq.default_worker_options's keys, fix #2124 2015-01-09 17:08:58 +00:00
grosser
57a06d00d6 allow every test to be run with just ruby test/xxx_test.rb 2014-12-30 12:54:58 -08:00
Mike Perham
77c57675ec Fix build 2014-05-13 14:00:20 -07:00
Peter M. Goldstein
1379f5093e Address assorted warnings 2014-03-19 17:47:08 -07:00
Mike Perham
2da06dcfe7 sigh 2014-03-11 21:21:21 -07:00
Mike Perham
1acd8ac627 Test correct event call 2014-03-10 20:51:10 -07:00
Mike Perham
3d117e6051 Implement process lifecycle events, fixes #1534 2014-03-10 20:46:19 -07:00
Mike Perham
babfdc96c5 Backport test suite to Minitest 4 so we can test against Rails 4. 2013-09-22 14:38:33 -07:00
Mike Perham
4679c95f49 Upgrade to Minitest 5 2013-05-12 14:25:30 -07:00
Christoph Olszowka
12b1b30147 Remedied requirement to bring your own table to the flipping method
See https://twitter.com/mperham/status/314141110513586177
2013-03-19 23:55:01 +01:00
Lior Sion
da61fd9fb4 replaced order of redis connection creation 2013-02-02 12:47:58 +02:00
Brandon Hilkert
d4df84e8b0 Update MultiJson delegate methods to coincide with their future API and
add supporting test.
2012-12-02 18:55:21 -05:00