1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00
Commit graph

9 commits

Author SHA1 Message Date
Mike Perham
b7996f4564 Better ActiveJob integration with Sidekiq options
This change allows ActiveJobs to directly use sidekiq_options to configure various Sidekiq internals/features, #4213
2019-07-24 10:52:54 -07:00
Phil Pirozhkov
fc575fbb7e Allow Sidekiq retry options in ActiveJob
c685d6928c
has introduced an exception that is raised on an attempt to include
Sidekiq::Worker to an ActiveJob::Base descendant.

That was done in order to prevent options not supported by ActiveJob,
specifically `queue`. See https://github.com/mperham/sidekiq/issues/2424

Support for `set` was added later on, including the setting of `retry`
from ActiveJob.
d6538b0b4f

This change bridges the gap by allowing ActiveJob::Base descendants to
include `Sidekiq::Options` and use `retry` option of
`sidekiq_options`, and also `sidekiq_retry_in`, and
`sidekiq_retries_exhausted`.
2019-07-24 09:39:12 -07:00
Mike Perham
85a1be3684 Switch all tests to use Minitest::Spec for consistency 2019-02-28 12:43:50 -08:00
Andrew Babichev
ddb0c8b3a8 Cleanup CLI (#4026)
* Refactor CLI test

Extracted 3 main parts:
- parse
- run
- signal handling

* Move demonization and pid write from parse to run phase

* Move queues default from validate to setup options phase

* Add pry-byebug gem

* Drop Sidekiq::Test

* Require launcher in CLI

* Remove TODOs
2018-12-03 13:24:37 -08:00
Mike Perham
2c9f7662fc Freeze all string literals in source, fixes #2741
Tests pass and smoke test works perfectly.
2015-12-31 15:33:35 -08:00
Mike Perham
53e6b9e2df Test suite overhaul
Remove Redis mocking.  Minimize Redis flushing where possible.
2015-09-23 10:56:37 -07:00
Mike Perham
b06acf627d fix build? 2015-07-13 22:45:52 -07:00
Mike Perham
0852312608 Verify test suite running with Rails 3.2 2015-07-13 22:00:22 -07:00
Mike Perham
c685d6928c Do not allow Sidekiq::Worker in AJ::Base classes, #2424
It will not work as intended and lead to much sorrow and misery.
2015-07-13 21:55:24 -07:00