1
0
Fork 0
mirror of https://github.com/mperham/sidekiq.git synced 2022-11-09 13:52:34 -05:00
Commit graph

7 commits

Author SHA1 Message Date
Matt Robinson
d4fca4683c
Fix logger with from deleting existing context (#4770)
If using `with` to add logging context, any context that has the same
keys as existing context will disappear after the with block completes,
instead of reverting back to the original context.

This fixes that by restoring the original context directly instead of
just deleting the keys from the `with` context.
2020-12-23 12:44:35 -08:00
Peter McCracken
ccc71d18a2
fix logger level query methods (#4463) 2020-02-14 08:18:44 -08:00
Kevin Deisz
cc1a37d006 Silence Ruby 2.7 warnings (#4412)
Since you can pass kwargs to Logger.new, you need to explicitly handle them in the subclass otherwise you get a warning.
2019-12-31 10:43:01 -08:00
Mike Perham
daabec1c7b refactor log context to not require context functionality on the logger itself, #4296 2019-10-01 19:19:26 -07:00
Andrew Babichev
db64467fc1 Pluggable Log Formatter (#4093)
* Rename log_format to log_formatter

Rails provides configuration options with this name.

* Pluggable log formatter instance
2019-02-11 13:59:52 -08:00
Mike Perham
022c63d86f Rework logger changes a bit
* logger_formatter -> log_format
* avoid touching global Sidekiq.logger in JobLogger
* rewrite tests for compactness and coverage
* hide banner in JSON
2018-12-29 07:54:05 -08:00
Andrew Babichev
3845832c20 JSON Logger Formatter (#4050)
* Check Config File Existence (#4054)

* Check config file existence

* Eager config file check

* Parse expanded path to default sidekiq.yml config file in Rails app

* Cleanup

* Add minitest-around

* Extract context from formatter

* Add JSON logger formatter

* Adjust job logger to handle elapsed time within context

* Add tid test

* Rename processor logger

* Enforce global state reset in logging tests

* Add warning about upcoming refactoring to Sidekiq::Logging

* Replace around hook with explicit stub inside test

It's implemented with fibers, which means Thread.current returns different values in JRuby.

* Fix typo

* Concise JSON formatter keys

* Add logger_formatter option

* Shift context from array of strings to hash

Allows more flexibly format context in the different formatters.

* Adjust warning message regarding context type change

* Add "Formatter" suffix to classes

* Fix CLI specs

* Replace Sidekiq::Logging with Sidekiq::Logger

* Namespace logger formatters

* Remove rails 4 appraisal
2018-12-28 15:05:51 -08:00