From d890700232c91d7f166d2128c22c4a6ee2030a1e Mon Sep 17 00:00:00 2001 From: Bobby McDonald Date: Fri, 28 Feb 2020 22:27:14 -0500 Subject: [PATCH] Fix failing tests --- spec/omniauth/strategy_spec.rb | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/spec/omniauth/strategy_spec.rb b/spec/omniauth/strategy_spec.rb index 982decf..de67005 100644 --- a/spec/omniauth/strategy_spec.rb +++ b/spec/omniauth/strategy_spec.rb @@ -242,7 +242,9 @@ describe OmniAuth::Strategy do describe '#redirect' do it 'uses javascript if :iframe is true' do response = ExampleStrategy.new(app, :iframe => true).redirect('http://abc.com') - expect(response.last.body.first).to be_include('top.location.href') + expected_body = "" + + expect(response.last).to include(expected_body) end end @@ -653,8 +655,8 @@ describe OmniAuth::Strategy do end it 'maintains host and port' do - response = strategy.call(make_env('/auth/test', 'rack.url_scheme' => 'http', 'HTTP_HOST' => 'example.org', 'SERVER_PORT' => 3000)) - expect(response[1]['Location']).to eq('http://example.org:3000/auth/test/callback') + response = strategy.call(make_env('/auth/test', 'rack.url_scheme' => 'http', 'SERVER_NAME' => 'example.org', 'SERVER_PORT' => 9292)) + expect(response[1]['Location']).to eq('http://example.org:9292/auth/test/callback') end it 'maintains query string parameters' do