kotovalexarian-likes-github/omniauth--omniauth
1
0
Fork 0
mirror of https://github.com/omniauth/omniauth.git synced 2022-11-09 12:31:49 -05:00
Code Releases Activity

Improve perf by using Hashie::Mash#[]

Browse source 
Hashie::Mash#method_missing is really slow, and it's called many times.
Running `rake perf:ips` from https://github.com/intridea/omniauth/pull/775
reveals a 60% performance boost.

Before:

  Calculating -------------------------------------
                   ips       649 i/100ms
  -------------------------------------------------
                   ips     6757.6 (±6.3%) i/s -      33748 in   5.013527s

After:

  Calculating -------------------------------------
                   ips      1028 i/100ms
  -------------------------------------------------
                   ips    10738.5 (±7.0%) i/s -      53456 in   5.001545s
This commit is contained in:
Janko Marohnić 2014-10-27 00:01:32 +01:00
parent 5121fde10d
commit f072a5183a
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
lib/omniauth/strategy.rb
View file

@ -132,7 +132,7 @@ module OmniAuth
@options = self.class.default_options.dup
options.deep_merge!(args.pop) if args.last.is_a?(Hash)
options.name ||= self.class.to_s.split('::').last.downcase
options[:name] ||= self.class.to_s.split('::').last.downcase
self.class.args.each do |arg|
break if args.empty?
@ -234,8 +234,8 @@ module OmniAuth
end
def on_request_path?
if options.request_path.respond_to?(:call)
options.request_path.call(env)
if options[:request_path].respond_to?(:call)
options[:request_path].call(env)
else
on_path?(request_path)
end
@ -299,7 +299,7 @@ module OmniAuth
if options[:setup].respond_to?(:call)
log :info, 'Setup endpoint detected, running now.'
options[:setup].call(env)
elsif options.setup?
elsif options[:setup]
log :info, 'Calling through to underlying application for setup.'
setup_env = env.merge('PATH_INFO' => setup_path, 'REQUEST_METHOD' => 'GET')
call_app!(setup_env)
@ -347,9 +347,9 @@ module OmniAuth
#
# use MyStrategy, :skip_info => lambda{|uid| User.find_by_uid(uid)}
def skip_info?
if options.skip_info?
if options.skip_info.respond_to?(:call)
return options.skip_info.call(uid)
if options[:skip_info]
if options[:skip_info].respond_to?(:call)
return options[:skip_info].call(uid)
else
return true
end
@ -445,7 +445,7 @@ module OmniAuth
end
def name
options.name
options[:name]
end
def redirect(uri)