Merge pull request #993 from BobbyMcWho/release-1_9_1

Release 1.9.1
This commit is contained in:
Bobby McDonald 2020-03-02 11:34:32 -06:00 committed by GitHub
commit fce9e23dd4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 7 additions and 5 deletions

View File

@ -1,3 +1,3 @@
module OmniAuth
VERSION = '1.9.0'.freeze
VERSION = '1.9.1'.freeze
end

View File

@ -10,7 +10,7 @@ if RUBY_VERSION >= '1.9'
SimpleCov.start do
add_filter ['/spec/', '/vendor/', 'strategy_macros.rb']
minimum_coverage(92.5)
maximum_coverage_drop(0.01)
maximum_coverage_drop(0.05)
end
end

View File

@ -242,7 +242,9 @@ describe OmniAuth::Strategy do
describe '#redirect' do
it 'uses javascript if :iframe is true' do
response = ExampleStrategy.new(app, :iframe => true).redirect('http://abc.com')
expect(response.last.body.first).to be_include('top.location.href')
expected_body = "<script type='text/javascript' charset='utf-8'>top.location.href = 'http://abc.com';</script>"
expect(response.last).to include(expected_body)
end
end
@ -653,8 +655,8 @@ describe OmniAuth::Strategy do
end
it 'maintains host and port' do
response = strategy.call(make_env('/auth/test', 'rack.url_scheme' => 'http', 'HTTP_HOST' => 'example.org', 'SERVER_PORT' => 3000))
expect(response[1]['Location']).to eq('http://example.org:3000/auth/test/callback')
response = strategy.call(make_env('/auth/test', 'rack.url_scheme' => 'http', 'SERVER_NAME' => 'example.org', 'SERVER_PORT' => 9292))
expect(response[1]['Location']).to eq('http://example.org:9292/auth/test/callback')
end
it 'maintains query string parameters' do