kotovalexarian-likes-github/paper-trail-gem--paper_trail
1
0
Fork 0
mirror of https://github.com/paper-trail-gem/paper_trail.git synced 2022-11-09 11:33:19 -05:00
Code Releases Activity
paper-trail-gem--paper_trail/Appraisals

27 lines
753 B
Text
Raw Normal View History

Lint: Style/FrozenStringLiteralComment
2017-12-10 23:05:11 -05:00
# frozen_string_literal: true
Manage gemfiles with appraisal
2016-01-04 22:32:39 -05:00
# Specify here only version constraints that differ from
# `paper_trail.gemspec`.
#
# > The dependencies in your Appraisals file are combined with dependencies in
Fix quotation marks [ci skip]
2016-05-09 10:20:56 -04:00
# > your Gemfile, so you don't need to repeat anything that's the same for each
Manage gemfiles with appraisal
2016-01-04 22:32:39 -05:00
# > appraisal. If something is specified in both the Gemfile and an appraisal,
# > the version from the appraisal takes precedence.
# > https://github.com/thoughtbot/appraisal
Tests: Explicitly specify rails as a dev. dependency spec/dummy_app needs rails. Technically, it only needs actionpack, but in case that changes in the future, I think we should just have rails as an explicit dependency. You may ask, if dummy_app has always needed actionpack, and our gemspec didn't explicitly specify the later, how did it ever work? It looks like we were getting actionpack as a transitive dependency.
2020-12-14 16:03:52 -05:00
#
#
Rename appraisals from ar- to rails-, per d9474bd
2020-12-15 12:43:29 -05:00
appraise "rails-5.2" do
Tests: Explicitly specify rails as a dev. dependency spec/dummy_app needs rails. Technically, it only needs actionpack, but in case that changes in the future, I think we should just have rails as an explicit dependency. You may ask, if dummy_app has always needed actionpack, and our gemspec didn't explicitly specify the later, how did it ever work? It looks like we were getting actionpack as a transitive dependency.
2020-12-14 16:03:52 -05:00
gem "rails", "~> 5.2.4"
Update dependencies: activerecord, rubocop
2018-08-14 01:29:08 -04:00
gem "rails-controller-testing", "~> 1.0.2"
Add support to Rails 5.2
2018-03-20 11:25:13 -04:00
end
Support rails 6.0.0 (#1172) * Change update_attributes to update In Rails 6.0 update_attributes/update_attributes! is considered deprecated. Method update/update! is the replacement. * CI: Don't use Bundler 1.16.1 - Bundler 1.16.1 has bug where dependencies can't be resolved properly when a gem is a release candidate or an alpha version. The underlying bundler issue can be found here https://github.com/bundler/bundler/issues/6449 * Disable eager_load in test env: - In Rails 6.0, rails/rails@3b95478 made a change to eagerly define attribute methods of a Model when `eager_load` is enabled. This breaks our test suite because of the way we run migration. The TL;DR is that doing `People.attribute_names` will return an empty array instead of `[:id, time_zone, ...]`. You can find a failing build here https://travis-ci.org/paper-trail-gem/paper_trail/jobs/463369634 Basically what happens is: 1) The dummy app boot, attribute methods of each model are defined but since migration didn't run yet, the tables aren't even created resulting in a empty attribute set. 2) Migration runs, but it's already too late. In this commit I disabled eager_loading in test, AFAIT there isn't much benefit in eager_loading the dummy app anyway. Also renaming the `user.rb` file to `postgres_user.rb` in order for rails autoloading to work correctly.
2018-12-04 16:10:35 -05:00
Rename appraisals from ar- to rails-, per d9474bd
2020-12-15 12:43:29 -05:00
appraise "rails-6.0" do
Tests: Explicitly specify rails as a dev. dependency spec/dummy_app needs rails. Technically, it only needs actionpack, but in case that changes in the future, I think we should just have rails as an explicit dependency. You may ask, if dummy_app has always needed actionpack, and our gemspec didn't explicitly specify the later, how did it ever work? It looks like we were getting actionpack as a transitive dependency.
2020-12-14 16:03:52 -05:00
gem "rails", "~> 6.0.3"
Support rails 6.0.0 (#1172) * Change update_attributes to update In Rails 6.0 update_attributes/update_attributes! is considered deprecated. Method update/update! is the replacement. * CI: Don't use Bundler 1.16.1 - Bundler 1.16.1 has bug where dependencies can't be resolved properly when a gem is a release candidate or an alpha version. The underlying bundler issue can be found here https://github.com/bundler/bundler/issues/6449 * Disable eager_load in test env: - In Rails 6.0, rails/rails@3b95478 made a change to eagerly define attribute methods of a Model when `eager_load` is enabled. This breaks our test suite because of the way we run migration. The TL;DR is that doing `People.attribute_names` will return an empty array instead of `[:id, time_zone, ...]`. You can find a failing build here https://travis-ci.org/paper-trail-gem/paper_trail/jobs/463369634 Basically what happens is: 1) The dummy app boot, attribute methods of each model are defined but since migration didn't run yet, the tables aren't even created resulting in a empty attribute set. 2) Migration runs, but it's already too late. In this commit I disabled eager_loading in test, AFAIT there isn't much benefit in eager_loading the dummy app anyway. Also renaming the `user.rb` file to `postgres_user.rb` in order for rails autoloading to work correctly.
2018-12-04 16:10:35 -05:00
gem "rails-controller-testing", "~> 1.0.3"
end
Add compatibility with Rails 6.1
2020-12-10 03:15:59 -05:00
Rename appraisals from ar- to rails-, per d9474bd
2020-12-15 12:43:29 -05:00
appraise "rails-6.1" do
Tests: various updates for rails 6.1
2020-12-15 12:38:55 -05:00
gem "rails", "~> 6.1.0"
Add compatibility with Rails 6.1
2020-12-10 03:15:59 -05:00
gem "rails-controller-testing", "~> 1.0.5"
end
Copy permalink