From 36b4032c0952e36112ff216f3fc65f145b0755ed Mon Sep 17 00:00:00 2001 From: Paul Padier Date: Thu, 31 Mar 2016 17:55:26 +0900 Subject: [PATCH] Explicitly disable Style/AccessorMethodName for set_transaction_id This method is doing a lot more than just setting transaction_id for self, so to me it doesn't make sense to rename it to transaction_id=. --- .rubocop_todo.yml | 5 ----- lib/paper_trail/has_paper_trail.rb | 2 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 0f64e2ae..7a0c4056 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -20,11 +20,6 @@ Metrics/ModuleLength: Metrics/PerceivedComplexity: Max: 16 -# Offense count: 1 -Style/AccessorMethodName: - Exclude: - - 'lib/paper_trail/has_paper_trail.rb' - # Offense count: 11 # Cop supports --auto-correct. # Configuration parameters: EnforcedStyle, SupportedStyles. diff --git a/lib/paper_trail/has_paper_trail.rb b/lib/paper_trail/has_paper_trail.rb index d9d90a9e..c68f8a44 100644 --- a/lib/paper_trail/has_paper_trail.rb +++ b/lib/paper_trail/has_paper_trail.rb @@ -456,7 +456,7 @@ module PaperTrail end end - def set_transaction_id(version) + def set_transaction_id(version) # rubocop:disable Style/AccessorMethodName return unless self.class.paper_trail_version_class.column_names.include?("transaction_id") if PaperTrail.transaction? && PaperTrail.transaction_id.nil? PaperTrail.transaction_id = version.id