From 3f9289d141d20e207a01f4ad94afd24a865ad57a Mon Sep 17 00:00:00 2001 From: Paul Padier Date: Fri, 1 Apr 2016 14:58:21 +0900 Subject: [PATCH] Fix Style/MutableConstant offenses --- .rubocop_todo.yml | 9 --------- lib/generators/paper_trail/templates/create_versions.rb | 2 +- lib/paper_trail/version_number.rb | 4 ++-- test/dummy/app/models/widget.rb | 2 +- test/unit/associations_test.rb | 2 +- 5 files changed, 5 insertions(+), 14 deletions(-) diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index bcec166b..27da2123 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -71,15 +71,6 @@ Style/MultilineTernaryOperator: - 'lib/paper_trail/has_paper_trail.rb' - 'lib/paper_trail/reifier.rb' -# Offense count: 4 -# Cop supports --auto-correct. -Style/MutableConstant: - Exclude: - - 'lib/generators/paper_trail/templates/create_versions.rb' - - 'lib/paper_trail/version_number.rb' - - 'test/dummy/app/models/widget.rb' - - 'test/unit/associations_test.rb' - # Offense count: 3 # Cop supports --auto-correct. Style/RescueModifier: diff --git a/lib/generators/paper_trail/templates/create_versions.rb b/lib/generators/paper_trail/templates/create_versions.rb index a45925b9..1fbccd90 100644 --- a/lib/generators/paper_trail/templates/create_versions.rb +++ b/lib/generators/paper_trail/templates/create_versions.rb @@ -5,7 +5,7 @@ class CreateVersions < ActiveRecord::Migration MYSQL_ADAPTERS = [ "ActiveRecord::ConnectionAdapters::MysqlAdapter", "ActiveRecord::ConnectionAdapters::Mysql2Adapter" - ] + ].freeze # The largest text column available in all supported RDBMS is # 1024^3 - 1 bytes, roughly one gibibyte. We specify a size diff --git a/lib/paper_trail/version_number.rb b/lib/paper_trail/version_number.rb index 104a9f4e..f13004b5 100644 --- a/lib/paper_trail/version_number.rb +++ b/lib/paper_trail/version_number.rb @@ -3,9 +3,9 @@ module PaperTrail MAJOR = 5 MINOR = 0 TINY = 0 - PRE = "pre" + PRE = "pre".freeze - STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".") + STRING = [MAJOR, MINOR, TINY, PRE].compact.join(".").freeze def self.to_s STRING diff --git a/test/dummy/app/models/widget.rb b/test/dummy/app/models/widget.rb index 2516cbb4..064a5f63 100644 --- a/test/dummy/app/models/widget.rb +++ b/test/dummy/app/models/widget.rb @@ -3,7 +3,7 @@ class Widget < ActiveRecord::Base has_one :wotsit has_many :whatchamajiggers, as: :owner - EXCLUDED_NAME = "Biglet" + EXCLUDED_NAME = "Biglet".freeze validates :name, exclusion: { in: [EXCLUDED_NAME] } diff --git a/test/unit/associations_test.rb b/test/unit/associations_test.rb index 8839e90a..91c6a9e7 100644 --- a/test/unit/associations_test.rb +++ b/test/unit/associations_test.rb @@ -15,7 +15,7 @@ class AssociationsTest < ActiveSupport::TestCase "The Lobster Quadrille", "Who Stole the Tarts?", "Alice's Evidence" - ] + ].freeze # These would have been done in test_helper.rb if using_mysql? is true unless using_mysql?