From 562f59d21a9cddb99911a908063e085982616b4a Mon Sep 17 00:00:00 2001 From: Jared Beck Date: Sun, 29 Aug 2021 22:09:51 -0400 Subject: [PATCH] Performance/CollectionLiteralInLoop --- .rubocop.yml | 5 +++++ .rubocop_todo.yml | 6 ------ 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index c8b01656..549ef8b2 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -123,6 +123,11 @@ Naming/MethodParameterName: Naming/VariableNumber: Enabled: false +# A valuable optimization in production code, but not valuable in specs. +Performance/CollectionLiteralInLoop: + Exclude: + - spec/**/* + # Good advice for rails applications, but not applicable to libraries like PT. Rails/SkipsModelValidations: Enabled: false diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index ae108738..c119bade 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -21,12 +21,6 @@ Metrics/CyclomaticComplexity: Metrics/PerceivedComplexity: Max: 9 # Goal: 7 -# Offense count: 1 -# Configuration parameters: MinSize. -Performance/CollectionLiteralInLoop: - Exclude: - - 'spec/models/version_spec.rb' - # Offense count: 115 # Configuration parameters: Prefixes. # Prefixes: when, with, without