rubocop 0.54.0 (was 0.51.0)

.rubocop.yml

@@ -17,6 +17,10 @@ AllCops:
   # Set to lowest supported version
   TargetRubyVersion: 2.3
 
+Bundler/OrderedGems:
+  Exclude:
+    - gemfiles/* # generated by Appraisal
+
 Layout/AlignParameters:
   EnforcedStyle: with_fixed_indentation
 
@@ -81,8 +85,10 @@ Naming/HeredocDelimiterNaming:
 Naming/PredicateName:
   NameWhitelist: has_paper_trail
 
-# In 0.50.0, this cop has a bug https://github.com/bbatsov/rubocop/issues/4732
-Performance/HashEachMethods:
+# Too subtle to lint.
+# Two-letter param names are OK. Consider `send_email(to:, cc:)`.
+# Even one-letter names are OK. Consider `draw_point(x, y)`.
+Naming/UncommunicativeMethodParamName:
   Enabled: false
 
 # In an ideal world, each example has a single expectation. In the real world,
@@ -108,16 +114,26 @@ Style/BlockDelimiters:
 Style/DoubleNegation:
   Enabled: false
 
+# Avoid annotated tokens except in desperately complicated format strings.
+# In 99% of format strings they actually make it less readable.
+Style/FormatStringToken:
+  Enabled: false
+
+Style/FrozenStringLiteralComment:
+  Exclude:
+    - gemfiles/* # generated by Appraisal
+
 # The decision of when to use a guard clause to improve readability is subtle,
 # and it's not clear that it can be linted. Certainly, the default
 # `MinBodyLength` of 1 can actually hurt readability.
 Style/GuardClause:
   Enabled: false
 
-# Use postfix (modifier) conditionals for one-liners, unless doing so would
-# exceed 60 characters.
+# Only use postfix (modifier) conditionals for utterly simple statements.
+# As a rule of thumb, the entire statement should not exceed 60 chars.
+# Rubocop used to support this level of configuration, but no longer does.
 Style/IfUnlessModifier:
-  MaxLineLength: 60
+  Enabled: false
 
 # The Ruby Style Guide says:
 #

.rubocop_todo.yml

@@ -12,6 +12,9 @@ Metrics/CyclomaticComplexity:
 Metrics/PerceivedComplexity:
   Max: 9 # Goal: 7
 
+Naming/MemoizedInstanceVariableName:
+  Enabled: false
+
 RSpec/InstanceVariable:
   Exclude:
     - spec/paper_trail/associations/belongs_to_spec.rb
@@ -31,3 +34,9 @@ RSpec/NestedGroups:
 # interface is a public API, so that would be a breaking change.
 Security/YAMLLoad:
   Enabled: false
+
+Style/ExpandPathArguments:
+  Enabled: false
+
+Style/RandomWithOffset:
+  Enabled: false

paper_trail.gemspec

@@ -40,7 +40,7 @@ has been destroyed.
   s.add_development_dependency "rack-test", [">= 0.6.3", "< 0.9"]
   s.add_development_dependency "rake", "~> 12.3"
   s.add_development_dependency "rspec-rails", "~> 3.7.2"
-  s.add_development_dependency "rubocop", "~> 0.51.0"
+  s.add_development_dependency "rubocop", "~> 0.54.0"
   s.add_development_dependency "rubocop-rspec", "~> 1.19.0"
   s.add_development_dependency "sqlite3", "~> 1.3"
   s.add_development_dependency "timecop", "~> 0.9.1"