1
0
Fork 0
mirror of https://github.com/paper-trail-gem/paper_trail.git synced 2022-11-09 11:33:19 -05:00

Merge pull request #1254 from tlynam/set-rubocop-performance-minor-version

This commit is contained in:
Anton Rieder 2020-08-09 11:47:49 +02:00 committed by GitHub
commit 8f73c1540e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 8 additions and 9 deletions

View file

@ -10,7 +10,7 @@ Metrics/AbcSize:
Max: 20 # Goal: 15 Max: 20 # Goal: 15
Metrics/CyclomaticComplexity: Metrics/CyclomaticComplexity:
Max: 7 # Goal: 6 Max: 8 # Goal: 7
Metrics/PerceivedComplexity: Metrics/PerceivedComplexity:
Max: 9 # Goal: 7 Max: 9 # Goal: 7

View file

@ -247,8 +247,7 @@ module PaperTrail
# @api private # @api private
def prepare_object_changes(changes) def prepare_object_changes(changes)
changes = serialize_object_changes(changes) changes = serialize_object_changes(changes)
changes = recordable_object_changes(changes) recordable_object_changes(changes)
changes
end end
# Returns an object which can be assigned to the `object_changes` # Returns an object which can be assigned to the `object_changes`

View file

@ -44,9 +44,9 @@ has been destroyed.
s.add_development_dependency "paper_trail-association_tracking", "~> 2.0.0" s.add_development_dependency "paper_trail-association_tracking", "~> 2.0.0"
s.add_development_dependency "rake", "~> 13.0" s.add_development_dependency "rake", "~> 13.0"
s.add_development_dependency "rspec-rails", "~> 4.0" s.add_development_dependency "rspec-rails", "~> 4.0"
s.add_development_dependency "rubocop", "~> 0.85.1" s.add_development_dependency "rubocop", "~> 0.88.0"
s.add_development_dependency "rubocop-performance", "~> 1.4" s.add_development_dependency "rubocop-performance", "~> 1.7.1"
s.add_development_dependency "rubocop-rspec", "~> 1.35" s.add_development_dependency "rubocop-rspec", "~> 1.42.0"
# ## Database Adapters # ## Database Adapters
# #

View file

@ -2,5 +2,5 @@
# This file is used by Rack-based servers to start the application. # This file is used by Rack-based servers to start the application.
require ::File.expand_path("../config/environment", __FILE__) require ::File.expand_path("config/environment", __dir__)
run Dummy::Application run Dummy::Application

View file

@ -12,7 +12,7 @@ module PaperTrail
specify { expect(PaperTrail.serializer).to be PaperTrail::Serializers::YAML } specify { expect(PaperTrail.serializer).to be PaperTrail::Serializers::YAML }
it "store out as a plain hash" do it "store out as a plain hash" do
expect(value =~ /HashWithIndifferentAccess/).to be_nil expect(value).not_to include("HashWithIndifferentAccess")
end end
end end
@ -46,7 +46,7 @@ module PaperTrail
end end
it "store out as a plain hash" do it "store out as a plain hash" do
expect(value =~ /HashWithIndifferentAccess/).to be_nil expect(value).not_to include("HashWithIndifferentAccess")
end end
after do after do