Update rubocop and friends

This commit is contained in:
Jared Beck 2019-08-06 00:46:54 -04:00
parent 80d446752a
commit a5bfb805e1
3 changed files with 23 additions and 18 deletions

View File

@ -104,6 +104,11 @@ Naming/UncommunicativeMethodParamName:
RSpec/DescribeClass: RSpec/DescribeClass:
Enabled: false Enabled: false
# This cop has a bug in 1.35.0
# https://github.com/rubocop-hq/rubocop-rspec/issues/799
RSpec/DescribedClass:
Enabled: false
# Yes, ideally examples would be short. Is it possible to pick a limit and say, # Yes, ideally examples would be short. Is it possible to pick a limit and say,
# "no example will ever be longer than this"? Hard to say. Sometimes they're # "no example will ever be longer than this"? Hard to say. Sometimes they're
# quite long. # quite long.

View File

@ -43,8 +43,8 @@ has been destroyed.
s.add_development_dependency "pg", "~> 1.0" s.add_development_dependency "pg", "~> 1.0"
s.add_development_dependency "rake", "~> 12.3" s.add_development_dependency "rake", "~> 12.3"
s.add_development_dependency "rspec-rails", "~> 3.8" s.add_development_dependency "rspec-rails", "~> 3.8"
s.add_development_dependency "rubocop", "~> 0.71.0" s.add_development_dependency "rubocop", "~> 0.74.0"
s.add_development_dependency "rubocop-performance", "~> 1.3.0" s.add_development_dependency "rubocop-performance", "~> 1.4"
s.add_development_dependency "rubocop-rspec", "~> 1.33.0" s.add_development_dependency "rubocop-rspec", "~> 1.35"
s.add_development_dependency "sqlite3", "~> 1.3.13" s.add_development_dependency "sqlite3", "~> 1.3.13"
end end

View File

@ -2,22 +2,22 @@
require "spec_helper" require "spec_helper"
RSpec.describe(::PaperTrail, versioning: true) do CHAPTER_NAMES = [
CHAPTER_NAMES = [ "Down the Rabbit-Hole",
"Down the Rabbit-Hole", "The Pool of Tears",
"The Pool of Tears", "A Caucus-Race and a Long Tale",
"A Caucus-Race and a Long Tale", "The Rabbit Sends in a Little Bill",
"The Rabbit Sends in a Little Bill", "Advice from a Caterpillar",
"Advice from a Caterpillar", "Pig and Pepper",
"Pig and Pepper", "A Mad Tea-Party",
"A Mad Tea-Party", "The Queen's Croquet-Ground",
"The Queen's Croquet-Ground", "The Mock Turtle's Story",
"The Mock Turtle's Story", "The Lobster Quadrille",
"The Lobster Quadrille", "Who Stole the Tarts?",
"Who Stole the Tarts?", "Alice's Evidence"
"Alice's Evidence" ].freeze
].freeze
RSpec.describe(::PaperTrail, versioning: true) do
context "Books, Authors, and Authorships" do context "Books, Authors, and Authorships" do
before { @book = Book.create(title: "book_0") } before { @book = Book.create(title: "book_0") }