From bf45280ce23a8f4c9990cee6edeefcf4830d8ba8 Mon Sep 17 00:00:00 2001 From: Jared Beck Date: Thu, 27 Apr 2017 00:09:34 -0400 Subject: [PATCH] Update dev. dependencies (#957) * rake 12.0.0 (was 10.4.2) rake 11 turns on interpreter warnings, which is why I added the `defined?` check to `@sibling_versions` * ffaker 2.5 (was 2.1) * shoulda ~> 3.5 (was ~> 3.5.0) --- lib/paper_trail/version_concern.rb | 2 +- paper_trail.gemspec | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/paper_trail/version_concern.rb b/lib/paper_trail/version_concern.rb index 5ab7326b..3f188e22 100644 --- a/lib/paper_trail/version_concern.rb +++ b/lib/paper_trail/version_concern.rb @@ -239,7 +239,7 @@ module PaperTrail alias version_author terminator def sibling_versions(reload = false) - if reload || @sibling_versions.nil? + if reload || !defined?(@sibling_versions) || @sibling_versions.nil? @sibling_versions = self.class.with_item_keys(item_type, item_id) end @sibling_versions diff --git a/paper_trail.gemspec b/paper_trail.gemspec index 000c9942..a027e380 100644 --- a/paper_trail.gemspec +++ b/paper_trail.gemspec @@ -29,9 +29,9 @@ has been destroyed. s.add_dependency "request_store", "~> 1.1" s.add_development_dependency "appraisal", "~> 2.1" - s.add_development_dependency "rake", "~> 10.4.2" - s.add_development_dependency "shoulda", "~> 3.5.0" - s.add_development_dependency "ffaker", "~> 2.1.0" + s.add_development_dependency "rake", "~> 12.0" + s.add_development_dependency "shoulda", "~> 3.5" + s.add_development_dependency "ffaker", "~> 2.5" # Why `railties`? Possibly used by `test/dummy` boot up? s.add_development_dependency "railties", [">= 4.0", "< 5.2"]