From df98728d2aff622d90b91a2d22bf4b1f8f5fcd16 Mon Sep 17 00:00:00 2001 From: Jared Beck Date: Tue, 15 Dec 2015 11:36:21 -0500 Subject: [PATCH] Remove my own misleading comment The `private` keyword does, in fact, make those instance methods private. I think what I was trying to say is that the host class (the class that VersionConcern is mixed into) will be able to use these methods. They *will* be private after being mixed in, but they are not "api private", if that makes sense. [ci skip] --- lib/paper_trail/version_concern.rb | 3 --- 1 file changed, 3 deletions(-) diff --git a/lib/paper_trail/version_concern.rb b/lib/paper_trail/version_concern.rb index 35c97130..104e44a6 100644 --- a/lib/paper_trail/version_concern.rb +++ b/lib/paper_trail/version_concern.rb @@ -255,9 +255,6 @@ module PaperTrail @index ||= RecordHistory.new(sibling_versions, self.class).index(self) end - # TODO: The `private` method has no effect here. Remove it? - # AFAICT it is not possible to have private instance methods in a mixin, - # though private *class* methods are possible. private # @api private