Commit Graph

30 Commits

Author SHA1 Message Date
Jared Beck 4d6f9bd0be Delete spec callback "verify_stubs: false" ..
.. we do not use it
2018-05-29 18:26:19 -04:00
Jared Beck 812c306892 Uninstall timecop
I'm hoping we don't actually need it because we explicitly enable
fractional seconds precision in our `dummy_app` migration by
specifying `limit(6)`.

Works on my machine, but I use mariadb. We'll see how well it works
on TravisCI, which runs mysql 5.6.33.

MySQL added support for `limit(6)` in 5.6.4, so I'm hopeful.
2018-05-14 22:31:12 -04:00
Jared Beck c0633be405 Lint: Style/ExpandPathArguments 2018-03-27 18:32:52 -04:00
Jared Beck da0b64d251 More work setting up tests against rails 5.2 2018-03-23 19:37:47 -04:00
Alex Evanczuk 04a58ee246 Add specs to request variables branch (#1052) 2018-02-27 00:14:33 -05:00
Jared Beck 6c8e408f0e We don't need database_cleaner except testing rails 4.2 2017-12-20 22:47:55 -05:00
Jared Beck cfbf7a647c Lint: Style/FrozenStringLiteralComment 2017-12-10 23:05:39 -05:00
Jared Beck c1d31b119d Switch debugger from pry to byebug 2017-10-27 11:42:43 -04:00
Jared Beck df4f3bba4f Lint: Fix various offenses, mostly rspec
- Fix Lint/RescueWithoutErrorClass
  - And I use the term "fix" loosely
- Fix RSpec/PredicateMatcher
  - The failure message should actually be better this way too.
- RSpec/LetBeforeExamples
- RSpec/HookArgument
- Fix RSpec/ExpectInHook in widget_spec.rb
- Fix RSpec/MessageSpies
  - I like spies. I've never linted them before, but I like how they
    separate test setup from assertions.
2017-09-19 01:25:53 -04:00
Jared Beck 94b9306647 Finish the conversion to RSpec
- Convert serializers/mixin_json_test.rb to rspec
- Convert functional/thread_safety_test.rb to rspec
- Convert functional/controller_test.rb to rspec
- Move the dummy app from test to spec, delete test dir
2017-06-10 01:45:46 -04:00
Jared Beck 38fa23873c Merge rails_helper into spec_helper
The reason some projects have both is so that some spec files can be
run in isolation, without the rails stuff. In practice, I don't find
myself ever doing this. So, the complexity of two files is unnecessary.
2017-05-30 00:59:55 -04:00
Jared Beck e276567901 Set RSpec config.order = random
Thankfully only one problematic spec.
2017-05-21 02:04:28 -04:00
Jared Beck c4148de9d0 Configure RSpec
Enable various standard configuration.
2017-05-21 02:04:28 -04:00
Jared Beck 7541497684 Disable ruby interpreter warnings 2017-05-21 01:29:58 -04:00
Jared Beck fe860a31eb Replace pry-nav with pry-byebug
pry-nav works, but produces a "circular require" warning.
The warning was fixed in 2016, but no new version of pry-nav
has been released.

https://github.com/nixme/pry-nav/pull/26

In fact, the pry-nav readme recommends using pry-byebug.
2017-05-15 12:20:35 -04:00
Jared Beck 8980f08d0e Fix Style/StringLiterals: Use double quotes 2016-03-05 17:07:32 -05:00
Jared Beck a8d896d87a Fix Style/BlockComments 2016-02-15 21:36:37 -05:00
Jared Beck 1f2e0fc53f Fix Lint/HandleExceptions 2016-02-15 19:53:13 -05:00
Jared Beck d86e6ec64c Break long lines in `spec` dir 2016-02-15 18:27:57 -05:00
Owen Rodda b9d9fb2e7c Update PaperTrail and test suite for ActiveRecord 5 compatibility 2016-01-24 19:57:10 -05:00
Jared Beck d138b955af MySQL: Specify utf8mb4 charset for versions table
Fixes #651
2015-12-27 17:59:20 -05:00
Jared Beck e9c7c70bbe Require pry-nav in spec_helper
Already done in test_helper, enables pry when running a single
spec.
2015-11-08 13:06:42 -05:00
Ben Atkins 716c3e0fb5 Use RSpec 3 for testing; Update syntax in spec suite for RSpec 3 2014-10-09 15:04:17 -04:00
Ben Atkins d7cfc17fdb Dicatate the correct spec support directory on the spec helper [ci skip] 2014-07-14 18:14:23 -04:00
Ben Atkins 618768853a Add warning messages to test helpers for the 'prepare' rake task to avoid confusion [ci skip] 2014-03-20 16:17:11 -04:00
Ben Atkins 6a6e4d1473 Fixing state leak issue for :enabled_for_controller? method with RSpec and Cucumber helpers. close #293 2013-11-16 18:59:22 -05:00
Ben Atkins 617c203a89 Adding :version_author alias for the :whodunnit attribute on Version class; adding some basic spec coverage for the Version class. close #284 2013-10-11 10:42:12 -04:00
Ben Atkins fdf85343a8 Removing ruby19 hash syntax from RSpec helper and specs to maintain Ruby18 compatibility. Changing the spec_helper to use the dummy app in the 'test' directory to avoid having two dummy apps. Adding 'rspec-rails' to the 3.0.gemfile so it can run the spec tests on Travis. 2013-08-27 17:35:36 -04:00
Ben Atkins e3a039b3db Improving the structure and syntax of the RSpec helper, modifying it to work with rspec in addition to rspec-rails 2013-08-27 15:12:33 -04:00
Paul Belt 4eaaac5dd8 specs for version; with_versioning helper for rspec
Conflicts:
	paper_trail.gemspec
2013-08-27 14:44:05 -04:00