Commit Graph

15 Commits

Author SHA1 Message Date
Jared Beck cfbf7a647c Lint: Style/FrozenStringLiteralComment 2017-12-10 23:05:39 -05:00
Jared Beck c2d5df8fde Lint: RSpec/BeforeAfterAll 2017-11-30 22:17:42 -05:00
Jared Beck 1af1d0dab0 Lint: Fix RSpec/FilePath 2017-10-17 18:37:43 -04:00
Jared Beck 38fa23873c Merge rails_helper into spec_helper
The reason some projects have both is so that some spec files can be
run in isolation, without the rails stuff. In practice, I don't find
myself ever doing this. So, the complexity of two files is unnecessary.
2017-05-30 00:59:55 -04:00
Jared Beck e2505c4f30 rubocop 0.48.1 (was 0.48.0) 2017-05-21 02:40:23 -04:00
Jared Beck ddde7857c5 Generate cleaner migrations 2017-04-10 11:35:18 -04:00
Jared Beck f92cfbc23d Inherit from the new versioned migration class
e.g. `ActiveRecord::Migration[5.1]`

Fixes #949

Following the example of the devise gem, use erb. In addition, add
the `.erb` file extension to fix syntax highlighting in editor.

Deletes create_versions_spec.rb because the file is no longer valid
ruby so those tests will have to be re-written. We can either
generate a valid ruby file and continue to use similar assertions,
or we can convert those features to use erb, which will have the
benefit of cleaner generated files.
2017-04-10 11:10:15 -04:00
Jared Beck 3df7dc27d2 Lint: Fix Lint/AmbiguousBlockAssociation 2017-04-01 00:33:33 -04:00
Jared Beck 0435936a37 Set MySQL collation: versions tbl: utf8mb4_general_ci
Should fix the "Unknown collation: 'utf8mb4_col'" error from
https://github.com/airblade/paper_trail/issues/741
2016-03-31 16:24:11 -04:00
Jared Beck 8980f08d0e Fix Style/StringLiterals: Use double quotes 2016-03-05 17:07:32 -05:00
Jared Beck 10941c8459 Fix Style/HashSyntax 2016-02-15 22:32:40 -05:00
Jared Beck d138b955af MySQL: Specify utf8mb4 charset for versions table
Fixes #651
2015-12-27 17:59:20 -05:00
Ben Atkins 716c3e0fb5 Use RSpec 3 for testing; Update syntax in spec suite for RSpec 3 2014-10-09 15:04:17 -04:00
Ben Atkins ed2e3d55e4 Remove word 'column' from migration to add 'object_changes' column to follow Rails convention 2014-03-07 16:28:04 -05:00
Ben Atkins 8cd1426b01 Add generator spec for InstallGenerator; Use 'change' method for migrations 2014-03-07 16:12:27 -05:00