2019-05-02 18:33:56 -04:00
|
|
|
# frozen_string_literal: true
|
|
|
|
|
Switch test suite to RSpec
Removes Bacon and Mocha
Reasoning explained in this comment: https://github.com/pry/pry/issues/277#issuecomment-51708712
Mostly this went smoothly. There were a few errors that I fixed along
the way, e.g. tests that were failing but for various reasons still
passed. Should have documented them, but didn't think about it until
very near the end. But generaly, I remember 2 reasons this would happen:
`lambda { raise "omg" }.should.raise(RuntimeError, /not-omg/)` will pass
because the second argument is ignored by Bacon. And `1.should == 2`
will return false instead of raising an error when it is not in an it
block (e.g. if stuck in a describe block, that would just return false)
The only one that I felt unsure about was spec/helpers/table_spec.rb
`Pry::Helpers.tablify_or_one_line('head', %w(ing)).should == 'head: ing'`
This is wrong, but was not failing because it was in a describe block
instead of an it block. In reality, it returns `"head: ing\n"`,
I updated the test to reflect this, though I don't know for sure
this is the right thing to do
This will fail on master until https://github.com/pry/pry/pull/1281 is merged.
This makes https://github.com/pry/pry/pull/1278 unnecessary.
2014-08-10 18:26:47 -04:00
|
|
|
describe "find-method" do
|
|
|
|
MyKlass = Class.new do
|
|
|
|
def hello
|
|
|
|
"timothy"
|
|
|
|
end
|
2018-10-14 02:23:34 -04:00
|
|
|
|
Switch test suite to RSpec
Removes Bacon and Mocha
Reasoning explained in this comment: https://github.com/pry/pry/issues/277#issuecomment-51708712
Mostly this went smoothly. There were a few errors that I fixed along
the way, e.g. tests that were failing but for various reasons still
passed. Should have documented them, but didn't think about it until
very near the end. But generaly, I remember 2 reasons this would happen:
`lambda { raise "omg" }.should.raise(RuntimeError, /not-omg/)` will pass
because the second argument is ignored by Bacon. And `1.should == 2`
will return false instead of raising an error when it is not in an it
block (e.g. if stuck in a describe block, that would just return false)
The only one that I felt unsure about was spec/helpers/table_spec.rb
`Pry::Helpers.tablify_or_one_line('head', %w(ing)).should == 'head: ing'`
This is wrong, but was not failing because it was in a describe block
instead of an it block. In reality, it returns `"head: ing\n"`,
I updated the test to reflect this, though I don't know for sure
this is the right thing to do
This will fail on master until https://github.com/pry/pry/pull/1281 is merged.
This makes https://github.com/pry/pry/pull/1278 unnecessary.
2014-08-10 18:26:47 -04:00
|
|
|
def goodbye
|
|
|
|
"jenny"
|
|
|
|
end
|
2018-10-14 02:23:34 -04:00
|
|
|
|
Switch test suite to RSpec
Removes Bacon and Mocha
Reasoning explained in this comment: https://github.com/pry/pry/issues/277#issuecomment-51708712
Mostly this went smoothly. There were a few errors that I fixed along
the way, e.g. tests that were failing but for various reasons still
passed. Should have documented them, but didn't think about it until
very near the end. But generaly, I remember 2 reasons this would happen:
`lambda { raise "omg" }.should.raise(RuntimeError, /not-omg/)` will pass
because the second argument is ignored by Bacon. And `1.should == 2`
will return false instead of raising an error when it is not in an it
block (e.g. if stuck in a describe block, that would just return false)
The only one that I felt unsure about was spec/helpers/table_spec.rb
`Pry::Helpers.tablify_or_one_line('head', %w(ing)).should == 'head: ing'`
This is wrong, but was not failing because it was in a describe block
instead of an it block. In reality, it returns `"head: ing\n"`,
I updated the test to reflect this, though I don't know for sure
this is the right thing to do
This will fail on master until https://github.com/pry/pry/pull/1281 is merged.
This makes https://github.com/pry/pry/pull/1278 unnecessary.
2014-08-10 18:26:47 -04:00
|
|
|
def tea_tim?
|
|
|
|
"timothy"
|
|
|
|
end
|
2018-10-14 02:23:34 -04:00
|
|
|
|
Switch test suite to RSpec
Removes Bacon and Mocha
Reasoning explained in this comment: https://github.com/pry/pry/issues/277#issuecomment-51708712
Mostly this went smoothly. There were a few errors that I fixed along
the way, e.g. tests that were failing but for various reasons still
passed. Should have documented them, but didn't think about it until
very near the end. But generaly, I remember 2 reasons this would happen:
`lambda { raise "omg" }.should.raise(RuntimeError, /not-omg/)` will pass
because the second argument is ignored by Bacon. And `1.should == 2`
will return false instead of raising an error when it is not in an it
block (e.g. if stuck in a describe block, that would just return false)
The only one that I felt unsure about was spec/helpers/table_spec.rb
`Pry::Helpers.tablify_or_one_line('head', %w(ing)).should == 'head: ing'`
This is wrong, but was not failing because it was in a describe block
instead of an it block. In reality, it returns `"head: ing\n"`,
I updated the test to reflect this, though I don't know for sure
this is the right thing to do
This will fail on master until https://github.com/pry/pry/pull/1281 is merged.
This makes https://github.com/pry/pry/pull/1278 unnecessary.
2014-08-10 18:26:47 -04:00
|
|
|
def tea_time?
|
|
|
|
"polly"
|
|
|
|
end
|
2013-10-24 01:58:26 -04:00
|
|
|
end
|
2012-04-01 03:51:11 -04:00
|
|
|
|
2013-10-24 01:58:26 -04:00
|
|
|
describe "find matching methods by name regex (-n option)" do
|
|
|
|
it "should find a method by regex" do
|
2015-03-10 16:49:29 -04:00
|
|
|
expect(pry_eval(binding, "find-method hell MyKlass")).to match(
|
2013-10-24 01:58:26 -04:00
|
|
|
/MyKlass.*?hello/m
|
2015-03-10 16:49:29 -04:00
|
|
|
)
|
2012-04-01 03:51:11 -04:00
|
|
|
end
|
|
|
|
|
2013-10-24 01:58:26 -04:00
|
|
|
it "should NOT match a method that does not match the regex" do
|
2015-03-10 16:49:29 -04:00
|
|
|
expect(pry_eval(binding, "find-method hell MyKlass")).not_to match(
|
2013-10-24 01:58:26 -04:00
|
|
|
/MyKlass.*?goodbye/m
|
2015-03-10 16:49:29 -04:00
|
|
|
)
|
2012-04-01 03:51:11 -04:00
|
|
|
end
|
2013-10-24 01:58:26 -04:00
|
|
|
end
|
2012-05-20 02:18:15 -04:00
|
|
|
|
2013-10-24 01:58:26 -04:00
|
|
|
describe "find matching methods by content regex (-c option)" do
|
|
|
|
it "should find a method by regex" do
|
2015-03-10 16:49:29 -04:00
|
|
|
expect(pry_eval(binding, "find-method -c timothy MyKlass")).to match(
|
2012-08-04 19:26:57 -04:00
|
|
|
/MyKlass.*?hello/m
|
2015-03-10 16:49:29 -04:00
|
|
|
)
|
2012-05-20 02:18:15 -04:00
|
|
|
end
|
2012-07-19 02:30:16 -04:00
|
|
|
|
2013-10-24 01:58:26 -04:00
|
|
|
it "should NOT match a method that does not match the regex" do
|
2015-03-10 16:49:29 -04:00
|
|
|
expect(pry_eval(binding, "find-method timothy MyKlass")).not_to match(
|
2013-10-24 01:58:26 -04:00
|
|
|
/MyKlass.*?goodbye/m
|
2015-03-10 16:49:29 -04:00
|
|
|
)
|
2012-07-19 02:30:16 -04:00
|
|
|
end
|
2012-04-01 03:51:11 -04:00
|
|
|
end
|
2012-04-01 15:30:17 -04:00
|
|
|
|
2013-10-24 01:58:26 -04:00
|
|
|
it "should work with badly behaved constants" do
|
|
|
|
MyKlass::X = Object.new
|
|
|
|
def (MyKlass::X).hash
|
|
|
|
raise "mooo"
|
|
|
|
end
|
|
|
|
|
2015-03-10 16:49:29 -04:00
|
|
|
expect(pry_eval(binding, "find-method -c timothy MyKlass")).to match(
|
2013-10-24 01:58:26 -04:00
|
|
|
/MyKlass.*?hello/m
|
2015-03-10 16:49:29 -04:00
|
|
|
)
|
2013-10-24 01:58:26 -04:00
|
|
|
end
|
|
|
|
|
|
|
|
it "should escape regexes correctly" do
|
|
|
|
good = /tea_time\?/
|
|
|
|
bad = /tea_tim\?/
|
2015-03-10 16:49:29 -04:00
|
|
|
expect(pry_eval(binding, 'find-method tea_time? MyKlass')).to match(good)
|
|
|
|
expect(pry_eval(binding, 'find-method tea_time? MyKlass')).to match(good)
|
|
|
|
expect(pry_eval(binding, 'find-method tea_time\? MyKlass')).not_to match(bad)
|
|
|
|
expect(pry_eval(binding, 'find-method tea_time\? MyKlass')).to match(good)
|
2013-10-24 01:58:26 -04:00
|
|
|
end
|
2012-04-01 19:21:37 -04:00
|
|
|
end
|