Merge pull request #1801 from pry/rubocop-lint-unused-method-argument

rubocop: fix offences of the Lint/UnusedMethodArgument cop

.rubocop_todo.yml

@@ -677,12 +677,6 @@ Lint/UnneededRequireStatement:
 Lint/UnusedBlockArgument:
   Enabled: false
 
-# Offense count: 22
-# Cop supports --auto-correct.
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
-Lint/UnusedMethodArgument:
-  Enabled: false
-
 # Offense count: 1
 Lint/UselessAssignment:
   Exclude:

lib/pry/code.rb

@@ -297,9 +297,8 @@ class Pry
     # Get the (approximate) Module.nesting at the give line number.
     #
     # @param [Integer] line_number line number starting from 1
-    # @param [Module] top_module the module in which this code exists
     # @return [Array<Module>] a list of open modules.
-    def nesting_at(line_number, top_module = Object)
+    def nesting_at(line_number)
       Pry::Indent.nesting_at(raw, line_number)
     end
 

lib/pry/command.rb

@@ -466,9 +466,9 @@ class Pry
 
     # Generate completions for this command
     #
-    # @param [String] search  The line typed so far
+    # @param [String] _search The line typed so far
     # @return [Array<String>]  Completion words
-    def complete(search)
+    def complete(_search)
       []
     end
 

lib/pry/commands/amend_line.rb

@@ -19,16 +19,15 @@ class Pry
     def process
       raise CommandError, "No input to amend." if eval_string.empty?
 
-      eval_string.replace amended_input(eval_string)
+      eval_string.replace(amend_input)
       run "fix-indent"
       run "show-input"
     end
 
     private
 
-    # @param [String] string The string to amend.
     # @return [String] A new string with the amendments applied to it.
-    def amended_input(string)
+    def amend_input
       input_array = eval_string.each_line.to_a
 
       if arg_string == "!"

lib/pry/commands/import_set.rb

@@ -10,7 +10,8 @@ class Pry
       Import a Pry command set.
     BANNER
 
-    def process(command_set_name)
+    # TODO: resolve unused parameter.
+    def process(_command_set_name)
       raise CommandError, "Provide a command set name" if command_set.nil?
 
       set = target.eval(arg_string)

lib/pry/commands/ri.rb

@@ -38,7 +38,7 @@ class Pry
             @pager.page(paging_text.string)
           end
 
-          def formatter(io)
+          def formatter(_io)
             if @formatter_klass
               @formatter_klass.new
             else

lib/pry/commands/watch_expression.rb

@@ -86,7 +86,9 @@ class Pry
       end
     end
 
-    def add_expression(arguments)
+    # TODO: fix arguments.
+    # https://github.com/pry/pry/commit/b031df2f2f5850ee6e9018f33d35f3485a9b0423
+    def add_expression(_arguments)
       expressions << Expression.new(_pry_, target, arg_string)
       output.puts "Watching #{Code.new(arg_string).highlighted}"
     end

lib/pry/helpers/base_helpers.rb

@@ -61,7 +61,7 @@ module Pry::Helpers::BaseHelpers
   # Send the given text through the best available pager (if Pry.config.pager is
   # enabled). Infers where to send the output if used as a mixin.
   # DEPRECATED.
-  def stagger_output(text, out = nil)
+  def stagger_output(text, _out = nil)
     if defined?(_pry_) && _pry_
       _pry_.pager.page text
     else

lib/pry/hooks.rb

@@ -15,7 +15,7 @@ class Pry
     end
 
     # Ensure that duplicates have their @hooks object.
-    def initialize_copy(orig)
+    def initialize_copy(_orig)
       hooks_dup = @hooks.dup
       @hooks.each do |k, v|
         hooks_dup[k] = v.dup

lib/pry/method.rb

@@ -166,7 +166,7 @@ class Pry
       #  please use {all_from_obj} instead.
       #  the `method_type` argument is ignored.
       #
-      def all_from_common(obj, method_type = nil, include_super=true)
+      def all_from_common(obj, _method_type = nil, include_super=true)
         all_from_obj(obj, include_super)
       end
 

lib/pry/method/disowned.rb

@@ -20,7 +20,7 @@ class Pry
       #
       # @param [Object] receiver
       # @param [String] method_name
-      def initialize(receiver, method_name, binding=nil)
+      def initialize(receiver, method_name)
         @receiver, @name = receiver, method_name
         @method = nil
       end

lib/pry/plugins.rb

@@ -8,7 +8,7 @@ class Pry
         @name = name
       end
 
-      def method_missing(*args)
+      def method_missing(*_args)
         warn "Warning: The plugin '#{@name}' was not found! (no gem found)"
       end
     end

lib/pry/pry_class.rb

@@ -396,7 +396,7 @@ Readline version #{Readline::VERSION} detected - will not auto_resize! correctly
     Thread.current[:pry_critical_section] > 0
   end
 
-  def self.critical_section(&block)
+  def self.critical_section
     Thread.current[:pry_critical_section] ||= 0
     Thread.current[:pry_critical_section] += 1
     yield

spec/command_set_spec.rb

@@ -656,7 +656,7 @@ describe Pry::CommandSet do
       end
 
       it "should delegate to commands" do
-        @set.create_command('susan'){ def complete(search); ['--foo']; end }
+        @set.create_command('susan'){ def complete(_search); ['--foo']; end }
         expect(@set.complete('susan ')).to eq ['--foo']
       end
     end

spec/command_spec.rb

@@ -226,11 +226,11 @@ describe "Pry::Command" do
           output.puts "setup"
         end
 
-        def subcommands(cmd)
+        def subcommands(_cmd)
           output.puts "subcommands"
         end
 
-        def options(opt)
+        def options(_opt)
           output.puts "options"
         end
 

spec/commands/cd_spec.rb

@@ -222,7 +222,7 @@ describe 'cd' do
   end
 
   it 'should cd into complex input (with spaces)' do
-    def @o.hello(x, y, z)
+    def @o.hello(_x, _y, _z)
       :mon_ouie
     end
 

spec/commands/show_source_spec.rb

@@ -47,7 +47,7 @@ describe "show-source" do
   end
 
   it "should find methods even if there are spaces in the arguments" do
-    def @o.foo(*bars)
+    def @o.foo(*_bars)
       @foo = "Mr flibble"
       self
     end
@@ -213,7 +213,7 @@ describe "show-source" do
   describe "finding super methods with help of `--super` switch" do
     before do
       class Foo
-        def foo(*bars)
+        def foo(*_bars)
           :super_wibble
         end
       end
@@ -226,7 +226,7 @@ describe "show-source" do
     it "finds super methods with explicit method argument" do
 
       o = Foo.new
-      def o.foo(*bars)
+      def o.foo(*_bars)
         :wibble
       end
 

spec/pry_spec.rb

@@ -76,7 +76,7 @@ describe Pry do
     # regression test for burg's bug (see git history)
     it "Should not error when object doesn't have a valid == method" do
       o = Object.new
-      def o.==(other)
+      def o.==(_other)
         raise
       end