Re factor "gem-list" command.
- Use Gem::Version in sort for accurate sorting. - Reduce complexity.
This commit is contained in:
parent
045f3fa8d5
commit
1c2e2a70b5
|
@ -38,19 +38,22 @@ class Pry
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|
||||||
command "gem-list", "List/search installed gems. (Optional parameter: a regexp to limit the search)" do |arg|
|
command "gem-list", "List/search installed gems. (Optional parameter: a regexp to limit the search)" do |pattern|
|
||||||
|
pattern = Regexp.new pattern.to_s, Regexp::IGNORECASE
|
||||||
gems = Gem.source_index.gems.values.group_by(&:name)
|
gems = Gem.source_index.gems.values.group_by(&:name)
|
||||||
if arg
|
|
||||||
query = Regexp.new(arg, Regexp::IGNORECASE)
|
gems.each do |gem, specs|
|
||||||
gems = gems.select { |gemname, specs| gemname =~ query }
|
if gem =~ pattern
|
||||||
|
specs.sort! do |a,b|
|
||||||
|
Gem::Version.new(b.version) <=> Gem::Version.new(a.version)
|
||||||
end
|
end
|
||||||
|
|
||||||
gems.each do |gemname, specs|
|
versions = specs.map.with_index do |spec, index|
|
||||||
versions = specs.map(&:version).sort.reverse.map(&:to_s)
|
index == 0 ? text.bright_green(spec.version.to_s) : text.green(spec.version.to_s)
|
||||||
versions = ["#{text.bright_green versions.first}"] + versions[1..-1].map{|v| "#{text.green v}" }
|
end
|
||||||
|
|
||||||
gemname = highlight(gemname, query) if query
|
output.puts "#{text.white gem} (#{versions.join ', '})"
|
||||||
output.puts "#{text.white gemname} (#{text.grey(versions.join ', ')})"
|
end
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|
Loading…
Reference in New Issue